fix: improve typescript types for Table class (#641)

googleapis · Mar 17, 2020 · 68179d1 · 68179d1
1 parent 87c2c6b
commit 68179d1
Show file tree

Hide file tree

Showing 5 changed files with 517 additions and 195 deletions.
diff --git a/src/family.ts b/src/family.ts
@@ -17,7 +17,6 @@
 import {promisifyAll} from '@google-cloud/promisify';
 import {CallOptions} from 'google-gax';
 import {ServiceError} from '@grpc/grpc-js';
-import * as is from 'is';
 
 import {Bigtable} from './';
 import {Table} from './table';
@@ -392,9 +391,9 @@ Please use the format 'follows' or '${table.name}/columnFamilies/my-family'.`);
         return;
       }
 
-      for (let i = 0, l = families.length; i < l; i++) {
-        if (families[i].name === this.name) {
-          this.metadata = families[i].metadata;
+      for (let i = 0, l = families!.length; i < l; i++) {
+        if (families![i].name === this.name) {
+          this.metadata = families![i].metadata;
           callback(null, this.metadata);
           return;
         }

diff --git a/src/index.ts b/src/index.ts
@@ -712,7 +712,10 @@ export class Bigtable {
    * @param {object} config.reqOpts Request options.
    * @param {function} [callback] Callback function.
    */
-  request(config, callback) {
+  request<T = any>(
+    config?: any,
+    callback?: (err: ServiceError | null, resp?: T) => void
+  ) {
     const isStreamMode = !callback;
 
     let gaxStream;
@@ -768,7 +771,7 @@ export class Bigtable {
     function makeRequestCallback() {
       prepareGaxRequest((err, requestFn) => {
         if (err) {
-          callback(err);
+          callback!(err);
           return;
         }