Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types): refactors index to export all types #548

Merged
merged 15 commits into from Oct 30, 2019
Merged

refactor(types): refactors index to export all types #548

merged 15 commits into from Oct 30, 2019

Conversation

steffnay
Copy link
Contributor

@steffnay steffnay commented Sep 21, 2019

Fixes #456

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2019
@codecov
Copy link

codecov bot commented Sep 21, 2019

Codecov Report

Merging #548 into master will increase coverage by <.01%.
The diff coverage is 98.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #548      +/-   ##
==========================================
+ Coverage   99.42%   99.43%   +<.01%     
==========================================
  Files           5        6       +1     
  Lines         698      707       +9     
  Branches      192      192              
==========================================
+ Hits          694      703       +9     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/dataset.ts 100% <ø> (ø) ⬆️
src/table.ts 100% <ø> (ø) ⬆️
src/job.ts 100% <ø> (ø) ⬆️
src/index.ts 100% <100%> (+1.49%) ⬆️
src/bigquery.ts 98.47% <98.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ec07f9...49c11bb. Read the comment docs.

@bcoe
Copy link
Contributor

bcoe commented Oct 1, 2019

@stephenplusplus I believe @callmehiphop might be away for a little bit? mind providing some review.

benchmark/bench.ts Outdated Show resolved Hide resolved
src/job.ts Outdated Show resolved Hide resolved
src/table.ts Outdated Show resolved Hide resolved
src/bigquery.ts Outdated Show resolved Hide resolved
test/bigquery.ts Outdated Show resolved Hide resolved
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2019
@bcoe bcoe added cla: yes This human has signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 28, 2019
@steffnay steffnay merged commit e7685c6 into googleapis:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't Import Useful Types From Main Declaration File
6 participants