Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for RANGE type #1352

Merged
merged 9 commits into from Apr 22, 2024
Merged

feat: add support for RANGE type #1352

merged 9 commits into from Apr 22, 2024
+586 −102

Conversation

alvarowolfx
Copy link
Contributor

@alvarowolfx alvarowolfx commented Apr 5, 2024 •
edited

Fixes #1344 🦕

BEGIN_COMMIT_OVERRIDE
chore: remove range support
END_COMMIT_OVERRIDE

@alvarowolfx alvarowolfx requested review from a team as code owners April 5, 2024 20:06
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Apr 5, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 8, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 8, 2024
@alvarowolfx alvarowolfx requested review from shollyman, Linchin and feywind and removed request for nayaknishant April 9, 2024 18:08
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 10, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 10, 2024
shollyman
shollyman approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but one question about what string formats we support.

src/bigquery.ts Show resolved Hide resolved
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 16, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 16, 2024
Linchin
Linchin reviewed Apr 16, 2024
View reviewed changes
src/bigquery.ts Outdated Show resolved Hide resolved
Linchin
Linchin reviewed Apr 16, 2024
View reviewed changes
src/bigquery.ts Outdated Show resolved Hide resolved
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 17, 2024
@Linchin Linchin self-requested a review April 18, 2024 18:22
Linchin
Linchin approved these changes Apr 18, 2024
View reviewed changes
Copy link

@Linchin Linchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the replies, I think the PR is already approved, but I'll just approve again in case you're waiting

@alvarowolfx alvarowolfx merged commit 1392422 into googleapis:main Apr 22, 2024
15 checks passed
@release-please release-please bot mentioned this pull request Apr 22, 2024
Merged
alvarowolfx added a commit that referenced this pull request Apr 25, 2024
@alvarowolfx
Revert "feat: add support for RANGE type (#1352)"
b1cf52f 
This reverts commit 1392422.
@alvarowolfx alvarowolfx mentioned this pull request Apr 25, 2024
Merged
alvarowolfx added a commit that referenced this pull request Apr 26, 2024
@alvarowolfx
Revert "feat: add support for RANGE type (#1352)" (#1358)
092bf17 
This reverts commit 1392422.
alvarowolfx added a commit to alvarowolfx/nodejs-bigquery that referenced this pull request Apr 26, 2024
@alvarowolfx
feat: add support for RANGE type (googleapis#1352)
a1f8ad6
@alvarowolfx alvarowolfx mentioned this pull request Apr 26, 2024
Merged
alvarowolfx added a commit that referenced this pull request May 3, 2024
@alvarowolfx
feat: add support for RANGE type (#1352) (#1360)
961a802
@release-please release-please bot mentioned this pull request May 3, 2024
Merged
This was referenced May 7, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@Linchin Linchin Linchin approved these changes

@feywind feywind Awaiting requested review from feywind

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for RANGE type
3 participants
@alvarowolfx @shollyman @Linchin