feat: switch timestamp representation to int64 usec

src/bigquery.ts

@@ -319,17 +319,17 @@
   location?: string;
   private _universeDomain: string;
 
   createQueryStream(options?: Query | string): ResourceStream<RowMetadata> {
     // placeholder body, overwritten in constructor
     return new ResourceStream<RowMetadata>({}, () => {});
   }
 
   getDatasetsStream(options?: GetDatasetsOptions): ResourceStream<Dataset> {
     // placeholder body, overwritten in constructor
     return new ResourceStream<Dataset>({}, () => {});
   }
 
   getJobsStream(options?: GetJobsOptions): ResourceStream<Job> {
     // placeholder body, overwritten in constructor
     return new ResourceStream<Job>({}, () => {});
   }
@@ -2217,15 +2217,10 @@
       if (/^\d{4}-\d{1,2}-\d{1,2}/.test(value)) {
         pd = new PreciseDate(value);
       } else {
-        const floatValue = Number.parseFloat(value);
-        if (!Number.isNaN(floatValue)) {
-          pd = this.fromFloatValue_(floatValue);
-        } else {
-          pd = new PreciseDate(value);
-        }
+        pd = new PreciseDate(BigInt(value) * BigInt(1000));
       }
     } else {
-      pd = this.fromFloatValue_(value);
+      pd = new PreciseDate(value);
     }
     // to keep backward compatibility, only converts with microsecond
     // precision if needed.
@@ -2235,15 +2230,6 @@
       this.value = new Date(pd.getTime()).toJSON();
     }
   }
-
-  fromFloatValue_(value: number): PreciseDate {
-    const secs = Math.trunc(value);
-    // Timestamps in BigQuery have microsecond precision, so we must
-    // return a round number of microseconds.
-    const micros = Math.trunc((value - secs) * 1e6 + 0.5);
-    const pd = new PreciseDate([secs, micros * 1000]);
-    return pd;
-  }
 }
 
 /**

src/job.ts

@@ -127,7 +127,7 @@
   location?: string;
   projectId?: string;
   getQueryResultsStream(
     options?: QueryResultsOptions
   ): ResourceStream<RowMetadata> {
     // placeholder body, overwritten in constructor
     return new ResourceStream<RowMetadata>({}, () => {});
@@ -529,10 +529,10 @@
       typeof optionsOrCallback === 'object' ? optionsOrCallback : {};
     const callback =
       typeof optionsOrCallback === 'function' ? optionsOrCallback : cb;
-
     const qs = extend(
       {
         location: this.location,
+        'formatOptions.useInt64Timestamp': true,
       },
       options
     );

src/table.ts

@@ -220,7 +220,7 @@
   bigQuery: BigQuery;
   location?: string;
   rowQueue?: RowQueue;
   createReadStream(options?: GetRowsOptions): ResourceStream<RowMetadata> {
     // placeholder body, overwritten in constructor
     return new ResourceStream<RowMetadata>({}, () => {});
   }
@@ -1848,10 +1848,17 @@
       callback!(null, rows, nextQuery, resp);
     };
 
+    const qs = extend(
+      {
+        'formatOptions.useInt64Timestamp': true,
+      },
+      options
+    );
+
     this.request(
       {
         uri: '/data',
-        qs: options,
+        qs,
       },
       (err, resp) => {
         if (err) {
@@ -1860,7 +1867,7 @@
         }
         let nextQuery: GetRowsOptions | null = null;
         if (resp.pageToken) {
-          nextQuery = Object.assign({}, options, {
+          nextQuery = Object.assign({}, qs, {
             pageToken: resp.pageToken,
           });
         }

test/job.ts

@@ -238,7 +238,10 @@ describe('BigQuery/Job', () => {
 
     it('should optionally accept options', done => {
       const options = {a: 'b'};
-      const expectedOptions = Object.assign({location: undefined}, options);
+      const expectedOptions = Object.assign(
+        {location: undefined, 'formatOptions.useInt64Timestamp': true},
+        options
+      );
 
       BIGQUERY.request = (reqOpts: DecorateRequestOptions) => {
         assert.deepStrictEqual(reqOpts.qs, expectedOptions);
@@ -252,7 +255,10 @@ describe('BigQuery/Job', () => {
       const job = new Job(BIGQUERY, JOB_ID, {location: LOCATION});
 
       BIGQUERY.request = (reqOpts: DecorateRequestOptions) => {
-        assert.deepStrictEqual(reqOpts.qs, {location: LOCATION});
+        assert.deepStrictEqual(reqOpts.qs, {
+          location: LOCATION,
+          'formatOptions.useInt64Timestamp': true,
+        });
         done();
       };
 
@@ -261,7 +267,11 @@ describe('BigQuery/Job', () => {
 
     it('should delete any cached jobs', done => {
       const options = {job: {}, a: 'b'};
-      const expectedOptions = {location: undefined, a: 'b'};
+      const expectedOptions = {
+        location: undefined,
+        a: 'b',
+        'formatOptions.useInt64Timestamp': true,
+      };
 
       BIGQUERY.request = (reqOpts: DecorateRequestOptions) => {
         assert.deepStrictEqual(reqOpts.qs, expectedOptions);
@@ -340,7 +350,10 @@ describe('BigQuery/Job', () => {
       const mergedRows: Array<{}> = [];
 
       const options = {wrapIntegers: true};
-      const expectedOptions = Object.assign({location: undefined});
+      const expectedOptions = Object.assign({
+        location: undefined,
+        'formatOptions.useInt64Timestamp': true,
+      });
 
       BIGQUERY.request = (reqOpts: DecorateRequestOptions) => {
         assert.deepStrictEqual(reqOpts.qs, expectedOptions);
@@ -368,7 +381,10 @@ describe('BigQuery/Job', () => {
       const mergedRows: Array<{}> = [];
 
       const options = {parseJSON: true};
-      const expectedOptions = Object.assign({location: undefined});
+      const expectedOptions = Object.assign({
+        location: undefined,
+        'formatOptions.useInt64Timestamp': true,
+      });
 
       BIGQUERY.request = (reqOpts: DecorateRequestOptions) => {
         assert.deepStrictEqual(reqOpts.qs, expectedOptions);

test/table.ts

@@ -1979,7 +1979,10 @@ describe('BigQuery/Table', () => {
 
       table.request = (reqOpts: DecorateRequestOptions, callback: Function) => {
         assert.strictEqual(reqOpts.uri, '/data');
-        assert.strictEqual(reqOpts.qs, options);
+        assert.deepStrictEqual(reqOpts.qs, {
+          ...options,
+          'formatOptions.useInt64Timestamp': true,
+        });
         callback(null, {});
       };
 
@@ -2129,14 +2132,18 @@ describe('BigQuery/Table', () => {
       table.metadata = {schema: {}};
 
       table.request = (reqOpts: DecorateRequestOptions, callback: Function) => {
-        callback(null, {pageToken});
+        callback(null, {
+          'formatOptions.useInt64Timestamp': true,
+          pageToken,
+        });
       };
 
       table.getRows(options, (err: Error, rows: {}, nextQuery: {}) => {
         assert.ifError(err);
         assert.deepStrictEqual(nextQuery, {
           a: 'b',
           c: 'd',
+          'formatOptions.useInt64Timestamp': true,
           pageToken,
         });
         // Original object isn't affected.
@@ -2257,7 +2264,9 @@ describe('BigQuery/Table', () => {
       const merged = [{name: 'stephen'}];
 
       table.request = (reqOpts: DecorateRequestOptions, callback: Function) => {
-        assert.deepStrictEqual(reqOpts.qs, {});
+        assert.deepStrictEqual(reqOpts.qs, {
+          'formatOptions.useInt64Timestamp': true,
+        });
         callback(null, {});
       };
 
@@ -2279,7 +2288,9 @@ describe('BigQuery/Table', () => {
       const merged = [{name: 'stephen'}];
 
       table.request = (reqOpts: DecorateRequestOptions, callback: Function) => {
-        assert.deepStrictEqual(reqOpts.qs, {});
+        assert.deepStrictEqual(reqOpts.qs, {
+          'formatOptions.useInt64Timestamp': true,
+        });
         callback(null, {});
       };