Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stricter typing for ServiceObject extensions #1263

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

fix: stricter typing for ServiceObject extensions #1263

wants to merge 16 commits into from

Conversation

loferris
Copy link
Contributor

@loferris loferris commented Aug 16, 2023 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1206 🦕

@loferris loferris requested review from a team as code owners August 16, 2023 00:33
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Aug 16, 2023
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Aug 17, 2023
@loferris loferris marked this pull request as draft August 21, 2023 22:40
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Aug 21, 2023
@loferris loferris added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2023
@loferris loferris marked this pull request as ready for review August 31, 2023 23:08
@loferris loferris self-assigned this Sep 27, 2023
ceifa
ceifa reviewed Mar 7, 2024
View reviewed changes
samples/getTable.js
/**Typescript Note:
* To narrow type from "any", cast the result of this method.
* const [table]: Dataset = await dataset.table(tableId).get();
* const table: Promise<GetResponse<Table>> = dataset.table(tableId).get();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetResponse is not exported by this library :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceifa ceifa ceifa left review comments

@alvarowolfx alvarowolfx alvarowolfx approved these changes

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@loferris loferris

Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript extending ServiceObject doesn't pass T causing service object methods to return untyped.
5 participants
@loferris @alvarowolfx @ceifa @yoshi-kokoro @meredithslota