Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stream): Fix table#createReadStream with startIndex #1178

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maximebedard
Copy link

Identical PR to #1100, but for table#createReadStream with a startIndex.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1099 馃

@maximebedard maximebedard requested a review from a team as a code owner January 17, 2023 19:50
@maximebedard maximebedard requested review from a team and prash-mi January 17, 2023 19:50
@google-cla
Copy link

google-cla bot commented Jan 17, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Jan 17, 2023
Emile-Filteau added a commit to Zapper-fi/nodejs-bigquery that referenced this pull request Jan 17, 2023
@maximebedard maximebedard force-pushed the fix-createReadStream-startIndex branch from acb1d55 to 83ece1f Compare January 19, 2023 18:03
@maximebedard maximebedard changed the title Fix table#createReadStream with startIndex fix(stream): Fix table#createReadStream with startIndex Jan 19, 2023
Copy link
Contributor

@loferris loferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks promising! We're going to need unit tests and integration tests before moving forward. It may be a while before I can write them myself, but if you'd like to take a look, I'd start by adding a unit test around here:

it('should make correct API request', done => {

@loferris loferris requested a review from a team as a code owner August 11, 2023 02:37
@loferris loferris self-assigned this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job#getQueryResultsStream fails when passed a startIndex
2 participants