fix(docs): configuration.copy link #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #709 +/- ##
==========================================
- Coverage 95.14% 95.14% -0.01%
==========================================
Files 7 7
Lines 6282 6279 -3
Branches 406 406
==========================================
- Hits 5977 5974 -3
Misses 305 305
Continue to review full report at Codecov.
|
stephenplusplus
suggested changes
May 29, 2020
|
@laljikanjareeya sorry that my review makes it look like everything is wrong! I just had some ideas for new phrasing, and tried to leave comments with code suggestions so you could just click to accept them and have the code update automatically. |
|
@stephenplusplus Thanks for the review, I made changes in one commit manually. Please take a look. |
stephenplusplus
approved these changes
Jun 1, 2020
|
@laljikanjareeya thank you! I approved, although there's a few quick formatting things. |
Co-authored-by: Stephen <stephenplusplus@users.noreply.github.com>
Co-authored-by: Stephen <stephenplusplus@users.noreply.github.com>
Co-authored-by: Stephen <stephenplusplus@users.noreply.github.com>
Co-authored-by: Stephen <stephenplusplus@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #708