Skip to content

fix(docs): fix formatting of the docs #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2019
Merged

fix(docs): fix formatting of the docs #513

merged 4 commits into from
Jul 31, 2019

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Jul 31, 2019

Fixes #504

Looking a little better ....

image

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2019
src/table.ts Outdated
@@ -1395,7 +1395,9 @@ class Table extends common.ServiceObject {
} as {},
request: {
uri: format('{base}/{projectId}/jobs', {
base: `https://${this.bigQuery.apiEndpoint}/upload/bigquery/v2/projects`,
base: `https://${
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is throwing a lint error? Might just need a fix

Copy link
Contributor

@callmehiphop callmehiphop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2019
@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #513 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #513   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files           5        5           
  Lines         698      698           
  Branches      192      192           
=======================================
  Hits          694      694           
  Misses          3        3           
  Partials        1        1
Impacted Files Coverage Δ
src/table.ts 100% <ø> (ø) ⬆️
src/index.ts 98.5% <ø> (ø) ⬆️
src/model.ts 100% <ø> (ø) ⬆️
src/dataset.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db74be7...a4baff7. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit d823014 into master Jul 31, 2019
@stephenplusplus stephenplusplus deleted the doccer branch November 26, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken code examples in BigQuery documentation
4 participants