build!: update library to use Node 12 (#1114)

* build!: Update library to use Node 12

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix error logging

* delete must refer to optional value

* dep: update gts

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

.github/sync-repo-settings.yaml

@@ -9,9 +9,9 @@ branchProtectionRules:
       - "ci/kokoro: System test"
       - docs
       - lint
-      - test (10)
       - test (12)
       - test (14)
+      - test (16)
       - cla/google
       - windows
       - OwlBot Post Processor

.github/workflows/ci.yaml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [10, 12, 14]
+        node: [12, 14, 16]
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3

benchmark/bench.ts

@@ -35,7 +35,7 @@ Promise.all(
 ).catch(console.error);
 
 async function doQuery(queryTxt: string) {
-  return new Promise((resolve, reject) => {
+  return new Promise<void>((resolve, reject) => {
     const startMilli = new Date().getTime();
     let numRows = 0;
     let numCols: number;

package.json

@@ -5,7 +5,7 @@
   "license": "Apache-2.0",
   "author": "Google LLC",
   "engines": {
-    "node": ">=10"
+    "node": ">=12.0.0"
   },
   "repository": "googleapis/nodejs-bigquery",
   "main": "./build/src/index.js",
@@ -79,17 +79,17 @@
     "codecov": "^3.5.0",
     "discovery-tsd": "^0.3.0",
     "execa": "^5.0.0",
-    "gts": "^3.0.0",
+    "gts": "^3.1.0",
     "jsdoc": "^3.6.3",
     "jsdoc-fresh": "^1.0.1",
     "jsdoc-region-tag": "^1.0.2",
     "linkinator": "^2.0.0",
-    "mocha": "^8.0.0",
+    "mocha": "^9.2.2",
     "mv": "^2.1.1",
     "ncp": "^2.0.0",
     "proxyquire": "^2.1.0",
     "sinon": "^14.0.0",
     "tmp": "0.2.1",
-    "typescript": "^3.8.3"
+    "typescript": "^4.6.4"
   }
 }

samples/package.json

@@ -10,7 +10,7 @@
   "author": "Google LLC",
   "repository": "googleapis/nodejs-bigquery",
   "engines": {
-    "node": ">=8"
+    "node": ">=12.0.0"
   },
   "scripts": {
     "test": "mocha --timeout 200000"
@@ -30,4 +30,4 @@
     "sinon": "^14.0.0",
     "uuid": "^8.0.0"
   }
-}
+}

src/bigquery.ts

@@ -2240,7 +2240,9 @@ export class BigQueryInt extends Number {
       try {
         return this.typeCastFunction!(this.value);
       } catch (error) {
-        error.message = `integerTypeCastFunction threw an error:\n\n  - ${error.message}`;
+        (error as Error).message = `integerTypeCastFunction threw an error:\n\n  - ${
+          (error as Error).message
+        }`;
         throw error;
       }
     } else {

src/table.ts

@@ -2118,16 +2118,16 @@ class Table extends ServiceObject {
     options: InsertRowsOptions
   ): Promise<bigquery.ITableDataInsertAllResponse> {
     const {partialRetries = 3} = options;
-    let error: Error;
+    let error: GoogleErrorBody;
 
     const maxAttempts = Math.max(partialRetries, 0) + 1;
 
     for (let attempts = 0; attempts < maxAttempts; attempts++) {
       try {
         return await this._insert(rows, options);
       } catch (e) {
-        error = e;
-        rows = ((e.errors || []) as PartialInsertFailure[])
+        error = e as GoogleErrorBody;
+        rows = (((e as GoogleErrorBody).errors || []) as PartialInsertFailure[])
           .filter(err => !!err.row)
           .map(err => err.row);
 

test/bigquery.ts

@@ -52,6 +52,16 @@ class FakeApiError {
   }
 }
 
+interface InputObject {
+  year?: number;
+  month?: number;
+  day?: number;
+  hours?: number;
+  minutes?: number;
+  seconds?: number;
+  fractional?: number;
+}
+
 interface CalledWithService extends Service {
   calledWith_: Array<{
     baseUrl: string;
@@ -763,7 +773,7 @@ describe('BigQuery', () => {
     });
 
     it('should not include fractional digits if not provided', () => {
-      const input = Object.assign({}, INPUT_OBJ);
+      const input = Object.assign({}, INPUT_OBJ) as InputObject;
       delete input.fractional;
 
       const time = bq.time(input);