Skip to content

Commit

Permalink
test: refactors system test deleteDatasets() (#754)
Browse files Browse the repository at this point in the history
* tests(system): adds check for creationTime

* refactor: replaces parsInt with Number

* test: refactor system test before hook

* test(refactor): checks dataset existence before attempting deletion

* chore: fix lint

* refactor: deleteDatasets
  • Loading branch information
steffnay committed Jun 17, 2020
1 parent 13b7e39 commit 6cde537
Showing 1 changed file with 13 additions and 11 deletions.
24 changes: 13 additions & 11 deletions system-test/bigquery.ts
Expand Up @@ -1698,16 +1698,18 @@ describe('BigQuery', () => {
filter: `labels.${GCLOUD_TESTS_PREFIX}`,
});

const deleteDatasetPromises = datasets
.filter(async dataset => {
const [metadata] = await dataset.getMetadata();
const creationTime = Number(metadata.creationTime);
return creationTime && isResourceStale(creationTime);
})
.map(dataset => {
return dataset.delete({force: true});
});

await Promise.all(deleteDatasetPromises);
for (const dataset of datasets) {
const [metadata] = await dataset.getMetadata();
const creationTime = Number(metadata.creationTime);

if (isResourceStale(creationTime)) {
try {
await dataset.delete({force: true});
} catch (e) {
console.log(`dataset(${dataset.id}).delete() failed`);
console.log(e);
}
}
}
}
});

0 comments on commit 6cde537

Please sign in to comment.