Skip to content

Commit

Permalink
docs(samples): updates test resource naming to improve traceability (#…
Browse files Browse the repository at this point in the history
…713)

* docs(samples): updates test resource naming to improve traceability

* linted
  • Loading branch information
steffnay committed Jun 9, 2020
1 parent b667139 commit 30064a7
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 9 deletions.
5 changes: 4 additions & 1 deletion samples/test/datasets.test.js
Expand Up @@ -22,7 +22,10 @@ const uuid = require('uuid');

const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});

const datasetId = `gcloud_tests_${uuid.v4()}`.replace(/-/gi, '_');
const datasetId = `nodejs_samples_tests_datasets_${uuid.v4()}`.replace(
/-/gi,
'_'
);
const bigquery = new BigQuery();

describe('Datasets', () => {
Expand Down
1 change: 0 additions & 1 deletion samples/test/jobs.test.js
Expand Up @@ -21,7 +21,6 @@ const cp = require('child_process');

const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});

// const datasetId = `gcloud_tests_${uuid.v4()}`.replace(/-/gi, '_');
const bigquery = new BigQuery();
let jobId;

Expand Down
20 changes: 16 additions & 4 deletions samples/test/models.test.js
Expand Up @@ -25,8 +25,14 @@ const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
const bigquery = new BigQuery();

describe('Models', () => {
const datasetId = `gcloud_tests_${uuid.v4()}`.replace(/-/gi, '_');
const modelId = `gcloud_tests_${uuid.v4()}`.replace(/-/gi, '_');
const datasetId = `nodejs_samples_tests_models_${uuid.v4()}`.replace(
/-/gi,
'_'
);
const modelId = `nodejs_samples_tests_models_${uuid.v4()}`.replace(
/-/gi,
'_'
);

before(async () => {
const query = `CREATE OR REPLACE MODEL \`${datasetId}.${modelId}\`
Expand Down Expand Up @@ -91,8 +97,14 @@ describe('Models', () => {
});

describe('Delete Model', () => {
const datasetId = `gcloud_tests_${uuid.v4()}`.replace(/-/gi, '_');
const modelId = `gcloud_tests_${uuid.v4()}`.replace(/-/gi, '_');
const datasetId = `nodejs_samples_tests_models_delete_${uuid.v4()}`.replace(
/-/gi,
'_'
);
const modelId = `nodejs_samples_tests_models_delete_${uuid.v4()}`.replace(
/-/gi,
'_'
);

before(async () => {
const query = `CREATE OR REPLACE MODEL \`${datasetId}.${modelId}\`
Expand Down
3 changes: 2 additions & 1 deletion samples/test/queries.test.js
Expand Up @@ -22,7 +22,8 @@ const uuid = require('uuid');
const {BigQuery} = require('@google-cloud/bigquery');

const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
const generateUuid = () => `gcloud-tests-${uuid.v4()}`.replace(/-/gi, '_');
const generateUuid = () =>
`nodejs_samples_tests_queries_${uuid.v4()}`.replace(/-/gi, '_');
const datasetId = generateUuid();
const tableId = generateUuid();
const destTableId = generateUuid();
Expand Down
5 changes: 4 additions & 1 deletion samples/test/quickstart.test.js
Expand Up @@ -25,7 +25,10 @@ const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
const bigquery = new BigQuery();

describe('Quickstart', () => {
const datasetName = `gcloud_tests_${uuid.v4()}`.replace(/-/gi, '_');
const datasetName = `nodejs_samples_tests_quickstart_${uuid.v4()}`.replace(
/-/gi,
'_'
);

after(async () => {
await bigquery.dataset(datasetName).delete({force: true});
Expand Down
3 changes: 2 additions & 1 deletion samples/test/tables.test.js
Expand Up @@ -25,7 +25,8 @@ const {BigQuery} = require('@google-cloud/bigquery');
const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});

const storage = new Storage();
const generateUuid = () => `gcloud-tests-${uuid.v4()}`.replace(/-/gi, '_');
const generateUuid = () =>
`nodejs_samples_tests_${uuid.v4()}`.replace(/-/gi, '_');

const datasetId = generateUuid();
const srcDatasetId = datasetId;
Expand Down

0 comments on commit 30064a7

Please sign in to comment.