feat(v1p3beta1,v1p4beta): breaking resource name changes (#133)

* chore!: enable gapicv2 for vision/v1p3beta API

BREAKING CHANGE: The breaking changes are as follows. After discussion please see this PR, these seem to be acceptable given that this is a beta API.

com.google.cloud.vision.v1p4beta1.ProductSearchClient: Parameter 2 of 'public void addProductToProductSet(com.google.cloud.vision.v1p4beta1.ProductSetName, java.lang.String)' has changed its type to com.google.cloud.vision.v1p4beta1.ProductName

com.google.cloud.vision.v1p4beta1.ProductSearchClient: Parameter 2 of 'public void removeProductFromProductSet(com.google.cloud.vision.v1p4beta1.ProductSetName, java.lang.String)' has changed its type to com.google.cloud.vision.v1p4beta1.ProductName

Committer: @miraleung
PiperOrigin-RevId: 309787157

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon May 4 11:38:06 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: ab3468cf63abc521be76c9eceb620d61c5ddd76a
Source-Link: googleapis/googleapis@ab3468c

* chore!: enable gapicv2 for vision/v1p4beta API

BREAKING CHANGE: The breaking changes are as follows. After discussion please see [this PR](googleapis/gapic-generator#3177), these seem to be acceptable given that this is a beta API.

com.google.cloud.vision.v1p4beta1.ProductSearchClient: Method 'public com.google.longrunning.Operation purgeProducts(com.google.cloud.vision.v1p4beta1.PurgeProductsRequest)' has been removed
- This is because this method was not generating with the same LRO interface that all other configured RPCs receive.

com.google.cloud.vision.v1p4beta1.ProductSearchClient: Parameter 2 of 'public void addProductToProductSet(com.google.cloud.vision.v1p4beta1.ProductSetName, java.lang.String)' has changed its type to com.google.cloud.vision.v1p4beta1.ProductName

com.google.cloud.vision.v1p4beta1.ProductSearchClient: Parameter 2 of 'public void removeProductFromProductSet(com.google.cloud.vision.v1p4beta1.ProductSetName, java.lang.String)' has changed its type to com.google.cloud.vision.v1p4beta1.ProductName

Committer: @miraleung
PiperOrigin-RevId: 309788146

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon May 4 11:42:36 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: a737a68e214d1cf927457c996b73e2600b14a949
Source-Link: googleapis/googleapis@a737a68

* chore: allow breaking resource names to beta clients

Co-authored-by: Jeff Ching <chingor@google.com>

google-cloud-vision/clirr-ignored-differences.xml

@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
+<differences>
+  <difference>
+    <differenceType>7005</differenceType>
+    <className>com/google/cloud/vision/v1p3beta1/ProductSearchClient</className>
+    <method>void *ProductSet(com.google.cloud.vision.v1p3beta1.ProductSetName, java.lang.String)</method>
+    <to>void *ProductSet(com.google.cloud.vision.v1p3beta1.ProductSetName, com.google.cloud.vision.v1p3beta1.ProductName)</to>
+  </difference>
+  <difference>
+    <differenceType>7005</differenceType>
+    <className>com/google/cloud/vision/v1p4beta1/ProductSearchClient</className>
+    <method>void *ProductSet(com.google.cloud.vision.v1p4beta1.ProductSetName, java.lang.String)</method>
+    <to>void *ProductSet(com.google.cloud.vision.v1p4beta1.ProductSetName, com.google.cloud.vision.v1p4beta1.ProductName)</to>
+  </difference>
+  <difference>
+    <differenceType>7002</differenceType>
+    <className>com/google/cloud/vision/v1p4beta1/ProductSearchClient</className>
+    <method>com.google.longrunning.Operation purgeProducts(com.google.cloud.vision.v1p4beta1.PurgeProductsRequest)</method>
+  </difference>
+</differences>

google-cloud-vision/src/main/java/com/google/cloud/vision/v1p3beta1/ImageAnnotatorClient.java

@@ -195,10 +195,7 @@ public final BatchAnnotateImagesResponse batchAnnotateImages(
    *
    * <pre><code>
    * try (ImageAnnotatorClient imageAnnotatorClient = ImageAnnotatorClient.create()) {
-   *   List&lt;AnnotateImageRequest&gt; requests = new ArrayList&lt;&gt;();
-   *   BatchAnnotateImagesRequest request = BatchAnnotateImagesRequest.newBuilder()
-   *     .addAllRequests(requests)
-   *     .build();
+   *   BatchAnnotateImagesRequest request = BatchAnnotateImagesRequest.newBuilder().build();
    *   BatchAnnotateImagesResponse response = imageAnnotatorClient.batchAnnotateImages(request);
    * }
    * </code></pre>
@@ -218,10 +215,7 @@ public final BatchAnnotateImagesResponse batchAnnotateImages(BatchAnnotateImages
    *
    * <pre><code>
    * try (ImageAnnotatorClient imageAnnotatorClient = ImageAnnotatorClient.create()) {
-   *   List&lt;AnnotateImageRequest&gt; requests = new ArrayList&lt;&gt;();
-   *   BatchAnnotateImagesRequest request = BatchAnnotateImagesRequest.newBuilder()
-   *     .addAllRequests(requests)
-   *     .build();
+   *   BatchAnnotateImagesRequest request = BatchAnnotateImagesRequest.newBuilder().build();
    *   ApiFuture&lt;BatchAnnotateImagesResponse&gt; future = imageAnnotatorClient.batchAnnotateImagesCallable().futureCall(request);
    *   // Do something
    *   BatchAnnotateImagesResponse response = future.get();