Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

fix: downcase translated text in Integration Test #425

Merged
merged 2 commits into from Feb 17, 2021
Merged

fix: downcase translated text in Integration Test #425

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abaeaad
fix: downcase translated text in Integration Test
Neenu1995 Feb 17, 2021
faf183e
chore: add locale to toLowerCase()
Neenu1995 Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 7 additions & 6 deletions google-cloud-translate/src/test/java/com/google/cloud/translate/it/ITTranslateTest.java
View file
Open in desktop
Expand Up @@ -32,6 +32,7 @@
import com.google.common.collect.ImmutableList;
import java.util.HashSet;
import java.util.List;
import java.util.Locale;
import java.util.Set;
import org.junit.Test;

Expand Down Expand Up @@ -104,10 +105,10 @@ public void testDetectLanguageOfText() {
public void testTranslateTextList() {
List<Translation> translations = TRANSLATE.translate(ImmutableList.of("ocho", "acht"));
Translation translation = translations.get(0);
assertEquals("eight", translation.getTranslatedText());
assertEquals("eight", translation.getTranslatedText().toLowerCase(Locale.ENGLISH));
assertEquals("es", translation.getSourceLanguage());
translation = translations.get(1);
assertEquals("eight", translation.getTranslatedText());
assertEquals("eight", translation.getTranslatedText().toLowerCase(Locale.ENGLISH));
assertEquals("de", translation.getSourceLanguage());
}

Expand All @@ -116,19 +117,19 @@ public void testTranslateTextListWithModel() {
List<Translation> translations =
TRANSLATE.translate(ImmutableList.of("ocho", "acht"), TranslateOption.model("nmt"));
Translation translation = translations.get(0);
assertEquals("eight", translation.getTranslatedText());
assertEquals("eight", translation.getTranslatedText().toLowerCase(Locale.ENGLISH));
assertEquals("es", translation.getSourceLanguage());
assertEquals("nmt", translation.getModel());
translation = translations.get(1);
assertEquals("eight", translation.getTranslatedText());
assertEquals("eight", translation.getTranslatedText().toLowerCase(Locale.ENGLISH));
assertEquals("de", translation.getSourceLanguage());
assertEquals("nmt", translation.getModel());
}

@Test
public void testTranslateText() {
Translation translation = TRANSLATE.translate("ocho");
assertEquals("eight", translation.getTranslatedText());
assertEquals("eight", translation.getTranslatedText().toLowerCase(Locale.ENGLISH));
assertEquals("es", translation.getSourceLanguage());
}

Expand Down Expand Up @@ -159,7 +160,7 @@ public void testDefaultCredentialsOverridesDefaultApiKey() {
public void testTranslateTextWithApiKey() {
Translate translate = RemoteTranslateHelper.create().getOptions().getService();
Translation translation = translate.translate("ocho");
assertEquals("eight", translation.getTranslatedText());
assertEquals("eight", translation.getTranslatedText().toLowerCase(Locale.ENGLISH));
assertEquals("es", translation.getSourceLanguage());
}
}