Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

fix: replace get("model") with translationPb.getModel() #242

Merged
merged 2 commits into from Jul 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -104,10 +104,9 @@ public final boolean equals(Object obj) {
}

static Translation fromPb(TranslationsResource translationPb) {
// TODO remove get("model") as soon as REST apiary supports model
return new Translation(
translationPb.getTranslatedText(),
translationPb.getDetectedSourceLanguage(),
(String) translationPb.get("model"));
translationPb.getModel());
}
}
Expand Up @@ -25,23 +25,27 @@ public class TranslationTest {

private static final String TRANSLATED_TEXT = "Hello world";
private static final String SOURCE_LANGUAGE = "en";
private static final String MODEL = "nmt";
private static final TranslationsResource TRANSLATION_PB =
new TranslationsResource()
.setTranslatedText(TRANSLATED_TEXT)
.setDetectedSourceLanguage(SOURCE_LANGUAGE);
.setDetectedSourceLanguage(SOURCE_LANGUAGE)
.setModel(MODEL);
private static final Translation TRANSLATION = Translation.fromPb(TRANSLATION_PB);

@Test
public void testFromPb() {
assertEquals(TRANSLATED_TEXT, TRANSLATION.getTranslatedText());
assertEquals(SOURCE_LANGUAGE, TRANSLATION.getSourceLanguage());
assertEquals(MODEL, TRANSLATION.getModel());
compareTranslation(TRANSLATION, Translation.fromPb(TRANSLATION_PB));
}

private void compareTranslation(Translation expected, Translation value) {
assertEquals(expected, value);
assertEquals(expected.getTranslatedText(), value.getTranslatedText());
assertEquals(expected.getSourceLanguage(), value.getSourceLanguage());
assertEquals(expected.getModel(), value.getModel());
assertEquals(expected.hashCode(), value.hashCode());
assertEquals(expected.toString(), value.toString());
}
Expand Down