Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(1.113.14-sp): backport critical bug fixes #993

Merged
merged 5 commits into from Sep 28, 2021
Merged

fix(1.113.14-sp): backport critical bug fixes #993

merged 5 commits into from Sep 28, 2021

Commits on Sep 1, 2021

  1. feat: Remove client side vaildation for lifecycle conditions (#816) 

    * Remove client side vaildation for lifecycle conditions

* fix lint and suggest updating

(cherry picked from commit 5ec84cc)
    @JesseLovelace @BenWhitehead
    JesseLovelace authored and BenWhitehead committed Sep 1, 2021
    Copy the full SHA
    1f2bb52 View commit details
    Browse the repository at this point in the history

  2. fix: update BucketInfo translation code to properly handle lifecycle … 

    …rules (#852)

Fixes #850

(cherry picked from commit 3b1df1d)
    @BenWhitehead
    BenWhitehead committed Sep 1, 2021
    Copy the full SHA
    b2d1f79 View commit details
    Browse the repository at this point in the history

  3. fix: improve error detection and reporting for BlobWriteChannel retry… 

    … state (#846)

Add new checks to ensure a more informative error than NullPointerException is thrown if the StorageObject or it's size are unable to be resolved on the last chunk.

Fixes #839

(cherry picked from commit d0f2184)
    @BenWhitehead
    BenWhitehead committed Sep 1, 2021
    Copy the full SHA
    895e3a3 View commit details
    Browse the repository at this point in the history

  4. fix: correct lastChunk retry logic in BlobWriteChannel (#918) 

    Add new method StorageRpc#queryResumableUpload which allows getting a shallow StorageObject for a resumable upload session which is complete.

Update BlobWriteChannel to use StoageRpc#queryResumableUpload instead of StorageRpc#get when attempting to validate the upload size of an object when it determines the upload is complete and is on the last chunk.

If a BlobWriteChannel is opened with a conditional like IfGenerationMatch it is not possible to simply get the object, as the object can drift generationally while the resumable upload is being performed.

Related to #839

(cherry picked from commit ab0228c)
    @BenWhitehead
    BenWhitehead committed Sep 1, 2021
    Copy the full SHA
    42e1f6e View commit details
    Browse the repository at this point in the history

  5. test: remove error string matching (#861) 

    It looks like the text for this error on the backend has changed
(sometimes) from "Precondition Failed" to "At least one of the
pre-conditions you specified did not hold". I don't think it's
really necessary to check the exact message in any case given
that we do check for a code of 412, which implies a precondition
failure. I added a check of the error Reason instead,  which is more
standardized.

Fixes #853

(cherry picked from commit 146a3d3)
    @tritone @BenWhitehead
    tritone authored and BenWhitehead committed Sep 1, 2021
    Copy the full SHA
    3f78624 View commit details
    Browse the repository at this point in the history