Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct lastChunk retry logic in BlobWriteChannel #918

Merged
merged 3 commits into from Jul 13, 2021
Merged

fix: correct lastChunk retry logic in BlobWriteChannel #918

merged 3 commits into from Jul 13, 2021

Commits on Jul 9, 2021

  1. fix: correct lastChunk retry logic in BlobWriteChannel 

    Add new method StorageRpc#queryResumableUpload which allows getting a shallow StorageObject for a resumable upload session which is complete.

Update BlobWriteChannel to use StoageRpc#queryResumableUpload instead of StorageRpc#get when attempting to validate the upload size of an object when it determines the upload is complete and is on the last chunk.

If a BlobWriteChannel is opened with a conditional like IfGenerationMatch it is not possible to simply get the object, as the object can drift generationally while the resumable upload is being performed.

Related to #839
    @BenWhitehead
    BenWhitehead committed Jul 9, 2021
    Copy the full SHA
    026b620 View commit details
    Browse the repository at this point in the history

  2. add javadoc, cleanup left over debugging comments

    @BenWhitehead
    BenWhitehead committed Jul 9, 2021
    Copy the full SHA
    8926244 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. rename method

    @BenWhitehead
    BenWhitehead committed Jul 13, 2021
    Copy the full SHA
    94cc687 View commit details
    Browse the repository at this point in the history