Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overescape #70

Closed
wants to merge 9 commits into from
Closed

Don't overescape #70

wants to merge 9 commits into from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jan 16, 2020

Fixes #57 To the extent the conformance tests allow, don't escape characters that don't need to be escaped. Deprecate the method that overescapes.

This should produce spec-compliant, canonically equivalent URLs. However do consider whether there's something on the server side or elsewhere that might cause signatures to no longer match. It depends on when, why, and how the signatures are calculated.

It might be worthwhile to break this PR up into smaller steps, but this is where we're heading.

@frankyn

@elharo elharo requested a review from frankyn January 16, 2020 15:19
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 16, 2020
@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@4e4225f). Click here to learn what that means.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #70   +/-   ##
=========================================
  Coverage          ?   63.34%           
  Complexity        ?      531           
=========================================
  Files             ?       30           
  Lines             ?     4730           
  Branches          ?      452           
=========================================
  Hits              ?     2996           
  Misses            ?     1571           
  Partials          ?      163
Impacted Files Coverage Δ Complexity Δ
...n/java/com/google/cloud/storage/SignatureInfo.java 81.2% <100%> (ø) 17 <0> (?)
...ain/java/com/google/cloud/storage/StorageImpl.java 76.85% <100%> (ø) 110 <0> (?)
.../google/cloud/storage/SignedUrlEncodingHelper.java 71.42% <80%> (ø) 5 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e4225f...26e3f81. Read the comment docs.

@elharo elharo closed this Feb 26, 2020
@BenWhitehead BenWhitehead deleted the plus branch October 25, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud Storage recently stopped handling the RFC 3986 URI encoding by it self
2 participants