Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update BOM to 3.2.0 #63

Merged
merged 1 commit into from Jan 15, 2020
Merged

chore(deps): Update BOM to 3.2.0 #63

merged 1 commit into from Jan 15, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jan 15, 2020

@kolea2 deliberately staying off 3.3.0 until #57 is fixed

@kolea2 deliberately staying off 3.3.0 until a bug is fixed here
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2020
@elharo elharo requested a review from kolea2 January 15, 2020 16:43
@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #63   +/-   ##
========================================
  Coverage      63.3%   63.3%           
  Complexity      528     528           
========================================
  Files            30      30           
  Lines          4720    4720           
  Branches        450     450           
========================================
  Hits           2988    2988           
  Misses         1571    1571           
  Partials        161     161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d467d96...142170d. Read the comment docs.

@kolea2
Copy link
Contributor

kolea2 commented Jan 15, 2020

LGTM but please amend the commit to get conventional commits passing (deps: ...)

@elharo elharo changed the title Update BOM to 3.2.0 chore(deps): Update BOM to 3.2.0 Jan 15, 2020
@elharo
Copy link
Contributor Author

elharo commented Jan 15, 2020

Is there documentation anywhere to explain what is actually required for conventional commits? I haven't been able to unravel that.

@elharo elharo merged commit 180ee5e into master Jan 15, 2020
@elharo elharo deleted the elharo-patch-1 branch January 15, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants