Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing Bucket and Blob FieldSelector #484

Merged
merged 1 commit into from Aug 28, 2020
Merged

fix: add missing Bucket and Blob FieldSelector #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java
View file
Open in desktop
Expand Up @@ -106,7 +106,9 @@ enum BucketField implements FieldSelector {
BILLING("billing"),
DEFAULT_EVENT_BASED_HOLD("defaultEventBasedHold"),
RETENTION_POLICY("retentionPolicy"),
IAMCONFIGURATION("iamConfiguration");
IAMCONFIGURATION("iamConfiguration"),
LOGGING("logging"),
UPDATED("updated");

static final List<? extends FieldSelector> REQUIRED_FIELDS = ImmutableList.of(NAME);

Expand Down Expand Up @@ -151,7 +153,8 @@ enum BlobField implements FieldSelector {
EVENT_BASED_HOLD("eventBasedHold"),
TEMPORARY_HOLD("temporaryHold"),
RETENTION_EXPIRATION_TIME("retentionExpirationTime"),
UPDATED("updated");
UPDATED("updated"),
CUSTOM_TIME("customTime");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely missed, thanks @athakor.


static final List<? extends FieldSelector> REQUIRED_FIELDS = ImmutableList.of(BUCKET, NAME);

Expand Down