Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): example of Storage#testIamPermissions #434

Merged
merged 1 commit into from Jul 15, 2020

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Jul 15, 2020

Fixes #433

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2020
@athakor athakor requested a review from frankyn July 15, 2020 10:03
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #434 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #434      +/-   ##
============================================
+ Coverage     63.19%   63.22%   +0.02%     
- Complexity      608      609       +1     
============================================
  Files            32       32              
  Lines          5111     5117       +6     
  Branches        472      488      +16     
============================================
+ Hits           3230     3235       +5     
  Misses         1717     1717              
- Partials        164      165       +1     
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/google/cloud/storage/Storage.java 80.90% <ø> (ø) 0.00 <0.00> (ø)
...main/java/com/google/cloud/storage/BucketInfo.java 81.57% <0.00%> (-0.14%) 83.00% <0.00%> (ø%)
...ain/java/com/google/cloud/storage/StorageImpl.java 81.00% <0.00%> (+0.04%) 138.00% <0.00%> (ø%)
...e/src/main/java/com/google/cloud/storage/Blob.java 82.18% <0.00%> (+0.10%) 30.00% <0.00%> (+1.00%)
...gle/cloud/storage/testing/RemoteStorageHelper.java 64.51% <0.00%> (+0.58%) 9.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05cbbda...f1c9d55. Read the comment docs.

@athakor athakor added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 15, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 15, 2020
@frankyn frankyn merged commit 275f452 into googleapis:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage[docs] : Fix example of Storage#testIamPermissions
4 participants