Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: catch actual exception in java doc comment #312

Merged
merged 5 commits into from May 13, 2020
Merged

docs: catch actual exception in java doc comment #312

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47dcb7f
docs: catch actual exception in java doc comment
suraj-qlogic May 12, 2020
16cf135
docs: fix review changes
suraj-qlogic May 12, 2020
bed6047
docs: fix review changes
suraj-qlogic May 13, 2020
7db165e
docs: fix review changes
suraj-qlogic May 13, 2020
f320ab8
docs: fix review changes
suraj-qlogic May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion google-cloud-storage/src/main/java/com/google/cloud/storage/Blob.java
View file
Open in desktop
Expand Up @@ -728,7 +728,7 @@ public ReadChannel reader(BlobSourceOption... options) {
* try (WriteChannel writer = blob.writer()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for the nested try block, one will do here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

* try {
* writer.write(ByteBuffer.wrap(content, 0, content.length));
* } catch (Exception ex) {
* } catch (IOException ex) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The end } isn't aligned with the opening try(). Please fix the spacing. This should be done below as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

* // handle exception
* }
* }
Expand Down
2 changes: 1 addition & 1 deletion google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java
View file
Open in desktop
Expand Up @@ -2505,7 +2505,7 @@ Blob create(
* try (WriteChannel writer = storage.writer(blobInfo)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't nest the try block, one is enough

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

* try {
* writer.write(ByteBuffer.wrap(content, 0, content.length));
* } catch (Exception ex) {
* } catch (IOException ex) {
* // handle exception
* }
* }
Expand Down