Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update dependency org.mockito:mockito-core to v3 #286

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Apr 28, 2020

This PR contains the following updates:

Package Update Change
org.mockito:mockito-core major 1.10.19 -> 3.3.3

Release Notes

mockito/mockito

v3.3.3

Compare Source

Release notes were automatically generated by Shipkit

3.3.3

v3.3.0

Compare Source

Release notes were automatically generated by Shipkit

3.3.0

v3.2.4

Compare Source

Release notes were automatically generated by Shipkit

3.2.4

v3.2.0

Compare Source

Release notes were automatically generated by Shipkit

3.2.0

v3.1.0

Compare Source

Release notes were automatically generated by Shipkit

3.1.0

v3.0.0

Compare Source

Mockito 3.0.0 is equivalent to Mockito 2, but now requires Java 8. No API changes were made.

v2.28.2

Compare Source

Release notes were automatically generated by Shipkit

2.28.2

v2.28.1

Compare Source

Release notes were automatically generated by Shipkit

2.28.1

v2.27.0

Compare Source

Release notes were automatically generated by Shipkit

2.27.0

v2.26.0

Compare Source

Release notes were automatically generated by Shipkit

2.26.0

v2.25.1

Compare Source

Release notes were automatically generated by Shipkit

2.25.1

v2.25.0

Compare Source

Release notes were automatically generated by Shipkit

2.25.0
  • 2019-03-05 - 11 commits by Szczepan Faber (10), Garfield Tan (1) - published to Bintray
  • New API to clean up all inline mocks after test (#​1619)
  • Memory leak in mockito-inline calling method on mock with at least a mock as parameter (#​1614)
  • Cross-references and a single spy cause memory leak (#​1533)
  • Nested spies cause memory leaks (#​1532)

v2.24.5

Compare Source

v2.24.0

Compare Source

v2.23.4

Compare Source

v2.23.0

Compare Source

v2.22.0

Compare Source

v2.21.0

Compare Source

v2.20.1

Compare Source

v2.20.0

Compare Source

v2.19.1

Compare Source

v2.19.0

Compare Source

v2.18.3

Compare Source

v2.18.0

Compare Source

v2.17.0

Compare Source

v2.16.0

Compare Source

v2.15.0

Compare Source

v2.13.0

Compare Source

v2.12.0

Compare Source

v2.11.0

Compare Source

v2.10.0

Compare Source

v2.9.0

Compare Source

v2.8.47

Compare Source

v2.8.9

Compare Source

v2.7.22

Compare Source

v2.7.21

Compare Source

v2.7.20

Compare Source

v2.7.19

Compare Source

v2.7.18

Compare Source

v2.7.17

Compare Source

v2.7.16

Compare Source

v2.7.15

Compare Source

v2.7.14

Compare Source

v2.7.13

Compare Source

v2.7.12

Compare Source

v2.7.11

Compare Source

v2.7.10

Compare Source

v2.7.9

Compare Source

v2.7.8

Compare Source

v2.7.7

Compare Source

v2.7.6

Compare Source

v2.7.5

Compare Source

v2.7.4

Compare Source

v2.7.3

Compare Source

v2.7.2

Compare Source

v2.6.9

Compare Source

v2.6.8

Compare Source

v2.6.7

Compare Source

v2.6.6

Compare Source

v2.6.5

Compare Source

v2.6.4

Compare Source

v2.6.3

Compare Source

v2.6.2

Compare Source

v2.6.1

Compare Source

v2.6.0

Compare Source

v2.5.7

Compare Source

v2.5.6

Compare Source

v2.5.5

Compare Source

v2.5.4

Compare Source

v2.5.3

Compare Source

v2.5.2

Compare Source

v2.5.1

Compare Source

v2.5.0

Compare Source

v2.4.5

Compare Source

v2.4.4

Compare Source

v2.4.3

Compare Source

v2.4.2

Compare Source

v2.4.1

Compare Source

v2.4.0

Compare Source

v2.3.11

Compare Source

v2.3.10

v2.3.6

Compare Source

v2.3.5

Compare Source

v2.3.4

Compare Source

v2.3.3

Compare Source

v2.3.2

Compare Source

v2.3.1

Compare Source

v2.3.0

Compare Source

v2.2.29

Compare Source

v2.2.28

Compare Source

v2.2.27

Compare Source

v2.2.26

Compare Source

v2.2.25

Compare Source

v2.2.24

Compare Source

v2.2.23

Compare Source

v2.2.22

Compare Source

v2.2.21

Compare Source

v2.2.20

Compare Source

v2.2.19

Compare Source

v2.2.18

Compare Source

v2.2.17

Compare Source

v2.2.16

Compare Source

v2.2.15

Compare Source

v2.2.14

Compare Source

v2.2.13

Compare Source

v2.2.12

Compare Source

v2.2.11

Compare Source

v2.2.10

Compare Source

v2.2.9

Compare Source

v2.2.8

Compare Source

v2.2.7

Compare Source

v2.2.6

Compare Source

v2.2.5

Compare Source

v2.2.4

Compare Source

v2.2.3

Compare Source

v2.2.2

Compare Source

v2.2.1

Compare Source

v2.2.0

Compare Source

v2.1.0

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 28, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 28, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 28, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 28, 2020
@frankyn
Copy link
Member

frankyn commented Apr 28, 2020

@elharo and @dmitry-fa, this is a bit concerning if we accidentally update this dependency it can cause Java 7 to no longer be supported.

We might want to not introduce mockito, not sure what other Java libraries are doing but is there a way to pin the version so it doesn't update?

@frankyn frankyn added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 28, 2020
@dmitry-fa
Copy link
Contributor

Hi @frankyn,

We might want to not introduce mockito, not sure what other Java libraries are doing but is there a way to pin the version so it doesn't update?

I guess to pin the version we need to define it right in dependency, not in the properties as it's done now:

  <properties>
    ...
    <mockito.version>1.10.19</mockito.version>
    ...
  </properties>

      <dependency>
        <groupId>org.mockito</groupId>
        <artifactId>mockito-core</artifactId>
        <version>${mockito.version}</version>
        <scope>test</scope>
      </dependency>

I can do this if it helps.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version doesn't seem to support Java 7. Try 2.28.2

@dmitry-fa
Copy link
Contributor

Done: #292

@frankyn frankyn closed this Apr 29, 2020
@renovate-bot renovate-bot deleted the renovate/major-mockito.version branch April 29, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants