New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add storage.upload(path) #269
Merged
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6af9ce2
feat: add storage.upload(path)
dmitry-fa 085739f
feat: use mockito framework
dmitry-fa 83ad702
feat: update upload to return blob
dmitry-fa 94d2948
feat: do not parse response from writers for signed urls
dmitry-fa e59bece
Merge branch 'master' into storageUpload3
dmitry-fa 0806031
Merge branch 'master' into storageUpload3
dmitry-fa 67a701e
fix reviewer's comments
dmitry-fa 41f1875
Merge branch 'master' into storageUpload3
dmitry-fa d62e615
Update Storage.upload() functionality after merge
dmitry-fa d55513f
feat: deprecate StorageRpc.write(), introduce StorageRpc.upload()
dmitry-fa 773d587
feat: deprecate StorageRpc.write(), introduce StorageRpc.upload()
dmitry-fa 0d9b17f
Merge branch 'master' into storageUpload3
dmitry-fa 3c9f2dc
Merge branch 'storageUpload3_next' into storageUpload3
dmitry-fa d7c7f1b
rename upload to createFrom
dmitry-fa File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html --> | ||
<differences> | ||
<difference> | ||
<differenceType>7012</differenceType> | ||
<className>com/google/cloud/storage/Storage</className> | ||
<method>*.Blob upload(*.BlobInfo, java.nio.file.Path, *.Storage$BlobWriteOption[])</method> | ||
</difference> | ||
<difference> | ||
<differenceType>7012</differenceType> | ||
<className>com/google/cloud/storage/Storage</className> | ||
<method>*.Blob upload(*.BlobInfo, java.io.InputStream, *.Storage$BlobWriteOption[])</method> | ||
</difference> | ||
<difference> | ||
<differenceType>7006</differenceType> | ||
<className>com/google/cloud/storage/spi/v1/StorageRpc</className> | ||
<method>void write(*.String, byte[], int, long, int, boolean)</method> | ||
<to>com.google.api.services.storage.model.StorageObject</to> | ||
</difference> | ||
<difference> | ||
<differenceType>7006</differenceType> | ||
<className>com/google/cloud/storage/spi/v1/HttpStorageRpc</className> | ||
<method>void write(*.String, byte[], int, long, int, boolean)</method> | ||
<to>com.google.api.services.storage.model.StorageObject</to> | ||
</difference> | ||
</differences> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you split out mockito tests into a separate PR because it got a bit confusing in review? Apologies for churn on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. Done #284