Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: surface storage interface expectations correctly. #241

Merged
merged 2 commits into from Apr 14, 2020
Merged

fix: surface storage interface expectations correctly. #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dea5367
fix: add @InternalExtensionOnly
frankyn Apr 13, 2020
423a4f4
fix: correct README.md
frankyn Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Expand Up @@ -216,7 +216,8 @@ See [TESTING] to read more about testing.
Versioning
----------

This library follows [Semantic Versioning](http://semver.org/).
This library follows [Semantic Versioning](http://semver.org/), but does update [Storage interface](src/main/java/com.google.cloud.storage/Storage.java)
to introduce new methods which can break your implementations if you implement this interface for testing purposes.

It is currently in major version one (``1.y.z``), which means that the public API should be considered stable.

Expand Down
2 changes: 2 additions & 0 deletions google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java
View file
Open in desktop
Expand Up @@ -19,6 +19,7 @@
import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.base.Preconditions.checkNotNull;

import com.google.api.core.InternalExtensionOnly;
import com.google.api.gax.paging.Page;
import com.google.auth.ServiceAccountSigner;
import com.google.auth.ServiceAccountSigner.SigningException;
Expand Down Expand Up @@ -55,6 +56,7 @@
*
* @see <a href="https://cloud.google.com/storage/docs">Google Cloud Storage</a>
*/
@InternalExtensionOnly
public interface Storage extends Service<StorageOptions> {

enum PredefinedAcl {
Expand Down