Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate Blob.update() and modify documentation of Storage.update methods #236

Closed
wants to merge 3 commits into from

Conversation

dmitry-fa
Copy link
Contributor

Fixes #234

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 10, 2020
@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #236 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #236   +/-   ##
=========================================
  Coverage     63.50%   63.50%           
  Complexity      540      540           
=========================================
  Files            30       30           
  Lines          4762     4762           
  Branches        427      427           
=========================================
  Hits           3024     3024           
  Misses         1578     1578           
  Partials        160      160           
Impacted Files Coverage Δ Complexity Δ
...e/src/main/java/com/google/cloud/storage/Blob.java 81.97% <ø> (ø) 29.00 <0.00> (ø)
...rc/main/java/com/google/cloud/storage/Storage.java 80.57% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15cb267...7991a9b. Read the comment docs.

@frankyn
Copy link
Member

frankyn commented Apr 10, 2020

Please wait to merge this until I have a chance to review next week.

@dmitry-fa
Copy link
Contributor Author

dmitry-fa commented Apr 10, 2020

@frankyn

Please wait to merge this until I have a chance to review next week.

Sure!

Please note, the doc has been updated to be aligned with
#233

@frankyn
Copy link
Member

frankyn commented Apr 14, 2020

Updated, please don't deprecate this method. It's a reasonable convenience method. I added an example in the associated issue.

Users may be dependent on this method and deprecating it can cause friction as we've seen before with the deprecation of Storage.create() for InputStream.

@frankyn frankyn closed this Apr 14, 2020
@dmitry-fa dmitry-fa deleted the BlobUpload branch June 26, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blob.update() misses BlobInfo argument
3 participants