Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update version resolution logic to be more resilient #2169

Merged
merged 2 commits into from Aug 23, 2023
Merged

fix: update version resolution logic to be more resilient #2169

merged 2 commits into from Aug 23, 2023

Commits on Aug 17, 2023

  1. fix: update version resolution logic to be more resilient 

    Update StorageOptions to resolve their version from maven metadata rather than manifest version. A jar can only have on MANIFEST.mf thereby leading to storage thinking it is a version it is not.

In particular, if a program is shaded, this change will now allow for the actual version of storage to be carried through.

Related googleapis/google-api-java-client#1419
    @BenWhitehead
    BenWhitehead committed Aug 17, 2023
    Copy the full SHA
    3fad05c View commit details
    Browse the repository at this point in the history

  2. chore: grpc too

    @BenWhitehead
    BenWhitehead committed Aug 17, 2023
    Copy the full SHA
    5bd61d6 View commit details
    Browse the repository at this point in the history