Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mismatch chunksize #135

Merged
merged 1 commit into from Feb 15, 2020
Merged

fix: mismatch chunksize #135

merged 1 commit into from Feb 15, 2020

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Feb 15, 2020

The default chunk size was increased in googleapis/java-core#87 and was not updated in java-storage unit tests.

This is a quick patch to unblock releasing changes needed to fix: #57

@elharo, thank you for your patience.

@frankyn frankyn requested a review from elharo February 15, 2020 01:10
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2020
@frankyn frankyn removed the request for review from elharo February 15, 2020 01:15
@codecov
Copy link

codecov bot commented Feb 15, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@753d870). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #135   +/-   ##
=========================================
  Coverage          ?   63.77%           
  Complexity        ?      540           
=========================================
  Files             ?       30           
  Lines             ?     4745           
  Branches          ?      456           
=========================================
  Hits              ?     3026           
  Misses            ?     1564           
  Partials          ?      155

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 753d870...578069c. Read the comment docs.

@frankyn frankyn merged commit 5da3e8d into master Feb 15, 2020
@frankyn frankyn deleted the fix-chunk-size branch February 15, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud Storage recently stopped handling the RFC 3986 URI encoding by it self
3 participants