New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add IAM Conditions support #120
Changes from 10 commits
187e98c
ef9a53d
f7e1609
1160ad5
938c9fe
d7a4077
f2013df
8ad5043
6284c40
7117481
8606ab7
cd2ead7
3941f5c
1dd8343
1bd1916
cff4242
95a17db
900a991
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,7 +63,7 @@ | |
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | ||
<github.global.server>github</github.global.server> | ||
<site.installationModule>google-cloud-storage-parent</site.installationModule> | ||
<google.core.version>1.92.5</google.core.version> | ||
<google.core.version>1.92.6-SNAPSHOT</google.core.version> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hard veto on this; we must not depend on snapshots. If this means we have to wait for a release of google core so be it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm doing this only for development* |
||
<google.api-common.version>1.8.1</google.api-common.version> | ||
<junit.version>4.13</junit.version> | ||
<threeten.version>1.4.1</threeten.version> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conditionals around asserts are a code smell. This should be two tests, one with and one without requesterPays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or two helper methods