Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for archive storage class #19

Merged
merged 3 commits into from Jan 6, 2020
Merged

feat: add support for archive storage class #19

merged 3 commits into from Jan 6, 2020

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Dec 27, 2019

Fixes #4

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 27, 2019
@codecov
Copy link

codecov bot commented Dec 27, 2019 •
edited

Codecov Report

Merging #19 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #19      +/-   ##
===========================================
+ Coverage     63.29%   63.3%   +<.01%     
  Complexity      528     528              
===========================================
  Files            30      30              
  Lines          4719    4720       +1     
  Branches        450     450              
===========================================
+ Hits           2987    2988       +1     
  Misses         1571    1571              
  Partials        161     161
Impacted Files Coverage Δ Complexity Δ
...in/java/com/google/cloud/storage/StorageClass.java 88.23% <100%> (+0.73%) 3 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda3eda...2232bcb. Read the comment docs.

@athakor athakor mentioned this pull request Dec 27, 2019
Closed
@chingor13 chingor13 requested review from frankyn and JesseLovelace and removed request for chingor13 December 27, 2019 17:40
tritone
tritone approved these changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We can go ahead and merge this with a plan to release the change between 1/2-8

kolea2
kolea2 reviewed Jan 2, 2020
View reviewed changes
google-cloud-storage/src/main/java/com/google/cloud/storage/StorageClass.java Outdated
/** Durable Reduced Availability (deprecated) */
/**
* Multi-regional storage class (deprecated).
* See:https://cloud.google.com/storage/docs/storage-classes for details
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a space after the : (same below too)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@JesseLovelace
Copy link
Contributor

We're avoiding the term "Deprecated" for these concepts currently and opting for "legacy". Please replace the (deprecated) notes with "This is supported as a legacy storage class and will be deprecated in the future"

@athakor
Copy link
Contributor Author

athakor commented Jan 3, 2020

We're avoiding the term "Deprecated" for these concepts currently and opting for "legacy". Please replace the (deprecated) notes with "This is supported as a legacy storage class and will be deprecated in the future"

done

kolea2
kolea2 reviewed Jan 3, 2020
View reviewed changes
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after minor javadoc update

google-cloud-storage/src/main/java/com/google/cloud/storage/StorageClass.java Outdated
public static final StorageClass ARCHIVE = type.createAndRegister("ARCHIVE");

/**
* Regional storage class.This is supported as a legacy storage class and will be deprecated in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a space - Regional storage class. This... (same below)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@athakor
Copy link
Contributor Author

athakor commented Jan 6, 2020

@kolea2 @JesseLovelace PTAL

@kolea2 kolea2 merged commit a3fbd67 into googleapis:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

@kolea2 kolea2 kolea2 approved these changes

@frankyn frankyn Awaiting requested review from frankyn

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Archive storage class
5 participants
@athakor @JesseLovelace @tritone @kolea2 @googlebot