Storage : Add support for Archive storage class #6685

athakor · 2019-11-04T11:36:14Z

tritone

Overall looks good, just one documentation thing to change.

Also, the feature is not publicly available yet, so please hold off on merging until I have approval on that.

tritone · 2019-11-06T21:13:29Z

...-cloud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage/StorageClass.java

@@ -56,6 +56,9 @@ public StorageClass apply(String constant) {
  /** Standard storage class. */
  public static final StorageClass STANDARD = type.createAndRegister("STANDARD");

+  /** Archive storage class. */


Regional and Multi-regional are also considered deprecated now. Let's add that to the comment for each of those and also add a link to https://cloud.google.com/storage/docs/storage-classes which has the most up-to-date information.

tritone · 2019-11-06T21:15:53Z

...loud-clients/google-cloud-storage/src/test/java/com/google/cloud/storage/BucketInfoTest.java

+          .setNotFoundPage(NOT_FOUND_PAGE)
+          .setLocation(LOCATION)
+          .setLocationType(LOCATION_TYPE)
+          .setStorageClass(ARCHIVE_STORAGE_CLASS)


Is it typical to set all of these options while creating a bucket in Java? Just curious.

No need to set all of these option but yes bucket name is required parameter see the api doc and example of create bucket

Okay, sounds good.

codecov · 2019-11-07T05:57:34Z

Codecov Report

Merging #6685 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #6685      +/-   ##
============================================
+ Coverage     46.35%   46.36%   +<.01%     
- Complexity    28005    28018      +13     
============================================
  Files          2613     2614       +1     
  Lines        288090   288195     +105     
  Branches      33783    33795      +12     
============================================
+ Hits         133534   133610      +76     
- Misses       144312   144334      +22     
- Partials      10244    10251       +7

Impacted Files	Coverage Δ	Complexity Δ
...in/java/com/google/cloud/storage/StorageClass.java	`88.23% <100%> (+0.73%)`	`3 <0> (ø)`	⬇️
...google/cloud/bigquery/StandardTableDefinition.java	`86.76% <0%> (-5.43%)`	`14% <0%> (ø)`
...main/java/com/google/cloud/storage/BucketInfo.java	`83.18% <0%> (-1.19%)`	`84% <0%> (ø)`
...a/com/google/cloud/bigquery/RangePartitioning.java	`75% <0%> (ø)`	`9% <0%> (?)`
...com/google/cloud/bigquery/QueryParameterValue.java	`72.72% <0%> (+0.35%)`	`46% <0%> (ø)`	⬇️
...om/google/cloud/bigquery/LoadJobConfiguration.java	`90.15% <0%> (+0.44%)`	`52% <0%> (+2%)`	⬆️
...m/google/cloud/bigquery/QueryJobConfiguration.java	`77.14% <0%> (+0.74%)`	`56% <0%> (+2%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8da3df...c2e02c8. Read the comment docs.

athakor · 2019-11-07T07:05:02Z

@tritone PTAL

tritone · 2019-11-11T22:04:05Z

...-cloud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage/StorageClass.java

+  /**
+   * Regional storage class (deprecated).
+   * See:https://cloud.google.com/storage/docs/per-object-storage-class for details
+   */
  public static final StorageClass REGIONAL = type.createAndRegister("REGIONAL");


Let's re-sort these as follows so that the non-deprecated classes come first: Standard, Nearline, Coldline, Archive, Regional, Multi-Regional, Durable Reduced Availability

tritone · 2019-11-11T22:04:20Z

...-cloud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage/StorageClass.java

-  /** Multi-regional storage class. */
+  /**
+   * Multi-regional storage class (deprecated).
+   * See:https://cloud.google.com/storage/docs/per-object-storage-class for details


This link redirects to https://cloud.google.com/storage/docs/storage-classes , so let's use that.

tritone · 2019-11-11T22:05:02Z

...loud-clients/google-cloud-storage/src/test/java/com/google/cloud/storage/BucketInfoTest.java

+          .setNotFoundPage(NOT_FOUND_PAGE)
+          .setLocation(LOCATION)
+          .setLocationType(LOCATION_TYPE)
+          .setStorageClass(ARCHIVE_STORAGE_CLASS)


Okay, sounds good.

athakor · 2019-11-12T06:25:50Z

@tritone all the comment have been addressed PTAL

tritone · 2019-11-13T18:40:16Z

@tritone all the comment have been addressed PTAL

Looks good to me! I will let you know when it's okay to merge (waiting until feature has been enabled without a flag).

tritone · 2019-12-20T18:02:55Z

This PR should no longer be merged because of the repo split. @athakor , could you re-create this PR in https://github.com/googleapis/java-storage ? Please let me know if you run into any issues.

Also, apologies for the delay on this-- we are now looking to merge the first week of Jan.

athakor · 2019-12-27T05:56:43Z

This PR should no longer be merged because of the repo split. @athakor , could you re-create this PR in https://github.com/googleapis/java-storage ? Please let me know if you run into any issues.

Also, apologies for the delay on this-- we are now looking to merge the first week of Jan.

done PR : googleapis/java-storage#19

athakor added 2 commits November 4, 2019 01:47

add 'ARCHIVE' storage class

383f6d7

Modified testcase

d2bcd57

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 4, 2019

athakor requested review from tritone, JesseLovelace and chingor13 November 4, 2019 12:08

tritone reviewed Nov 6, 2019

View reviewed changes

Fix review changes

2afbbf7

tritone reviewed Nov 11, 2019

View reviewed changes

Fix review changes

c2e02c8

chingor13 added the api: storage Issues related to the Cloud Storage API. label Dec 6, 2019

tritone mentioned this pull request Dec 20, 2019

Add support for Archive storage class googleapis/java-storage#4

Closed

athakor closed this Dec 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Storage : Add support for Archive storage class #6685

Storage : Add support for Archive storage class #6685

athakor commented Nov 4, 2019

tritone left a comment

tritone Nov 6, 2019

athakor Nov 7, 2019

tritone Nov 6, 2019

athakor Nov 7, 2019 •

edited

tritone Nov 11, 2019

codecov bot commented Nov 7, 2019 •

edited

athakor commented Nov 7, 2019 •

edited

tritone Nov 11, 2019

athakor Nov 12, 2019

tritone Nov 11, 2019

athakor Nov 12, 2019

tritone Nov 11, 2019

athakor commented Nov 12, 2019

tritone commented Nov 13, 2019

tritone commented Dec 20, 2019

athakor commented Dec 27, 2019 •

edited

Storage : Add support for Archive storage class #6685

Storage : Add support for Archive storage class #6685

Conversation

athakor commented Nov 4, 2019

tritone left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

athakor Nov 7, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Nov 7, 2019 • edited

Codecov Report

athakor commented Nov 7, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

athakor commented Nov 12, 2019

tritone commented Nov 13, 2019

tritone commented Dec 20, 2019

athakor commented Dec 27, 2019 • edited

athakor Nov 7, 2019 •

edited

codecov bot commented Nov 7, 2019 •

edited

athakor commented Nov 7, 2019 •

edited

athakor commented Dec 27, 2019 •

edited