feat: implement getNotification inside StorageRpcTestBase class and f…

…ix the builds checks
googleapis · Jun 18, 2020 · 300c604 · 300c604
1 parent 1947152
commit 300c604
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 3 deletions.
diff --git a/google-cloud-storage/src/main/java/com/google/cloud/storage/testing/StorageRpcTestBase.java b/google-cloud-storage/src/main/java/com/google/cloud/storage/testing/StorageRpcTestBase.java
@@ -280,6 +280,11 @@ public Notification createNotification(String bucket, Notification notification)
     throw new UnsupportedOperationException("Not implemented yet");
   }
 
+  @Override
+  public Notification getNotification(String bucket, String notification) {
+    throw new UnsupportedOperationException("Not implemented yet");
+  }
+
   @Override
   public Bucket lockRetentionPolicy(Bucket bucket, Map<Option, ?> options) {
     throw new UnsupportedOperationException("Not implemented yet");

diff --git a/google-cloud-storage/src/test/java/com/google/cloud/storage/StorageImplTest.java b/google-cloud-storage/src/test/java/com/google/cloud/storage/StorageImplTest.java
@@ -57,7 +57,6 @@
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.Iterables;
 import com.google.common.io.BaseEncoding;
-import java.io.ByteArrayInputStream;
 import java.io.IOException;
 import java.io.UnsupportedEncodingException;
 import java.net.MalformedURLException;
@@ -2558,6 +2557,6 @@ private void compareBucketsNotification(Notification value) {
     assertEquals(EVENT_TYPES, value.getEventTypes());
     assertEquals(OBJECT_NAME_PREFIX, value.getObjectNamePrefix());
     assertEquals(PAYLOAD_FORMAT.name(), value.getPayloadFormat());
-    assertEquals(TOPIC.toString(), value.getTopic());
+    assertEquals(TOPIC, value.getTopic());
   }
 }
diff --git a/...-cloud-storage/src/test/java/com/google/cloud/storage/testing/StorageRpcTestBaseTest.java b/...-cloud-storage/src/test/java/com/google/cloud/storage/testing/StorageRpcTestBaseTest.java
@@ -577,6 +577,17 @@ public Notification call() {
         };
   }
 
+  @Test
+  public void testGetNotification() {
+    rpc =
+        new Callable<Notification>() {
+          @Override
+          public Notification call() {
+            return STORAGE_RPC.getNotification("bucket", "notification");
+          }
+        };
+  }
+
   @Test
   public void testLockRetentionPolicy() {
     rpc =

diff --git a/pom.xml b/pom.xml
@@ -83,7 +83,7 @@
       <dependency>
         <groupId>com.google.cloud</groupId>
         <artifactId>google-cloud-pubsub</artifactId>
-        <version>1.105.0</version>
+        <version>1.106.0</version>
         <scope>test</scope>
       </dependency>
       <dependency>