Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update FakeStorageRpc to extend StorageRpcTestBase #135 #148

Merged
merged 1 commit into from Jun 18, 2020

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Jun 18, 2020

Force release of fix #135
Fixes: #147

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2020
@frankyn frankyn requested a review from chingor13 June 18, 2020 00:41
Copy link
Collaborator

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merge this as fix: update FakeStorageRpc to extend StorageRpcTestBase #135 so that it appears nicer in the release notes

@frankyn frankyn changed the title fix: release fix #135 fix: update FakeStorageRpc to extend StorageRpcTestBase #135 Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #148   +/-   ##
=========================================
  Coverage     71.43%   71.43%           
  Complexity      483      483           
=========================================
  Files            29       29           
  Lines          1642     1642           
  Branches        265      265           
=========================================
  Hits           1173     1173           
  Misses          345      345           
  Partials        124      124           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a12b591...9e7d30e. Read the comment docs.

@frankyn frankyn merged commit 7614295 into master Jun 18, 2020
@frankyn frankyn deleted the force-release branch June 18, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release PRs are not being created
3 participants