Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: all throwables should be ignored in shutdown hook #950

Merged
merged 1 commit into from Mar 16, 2021
Merged

fix: all throwables should be ignored in shutdown hook #950

merged 1 commit into from Mar 16, 2021

Commits on Mar 11, 2021

  1. fix: all throwables should be ignored in shutdown hook 

    All throwables (and not just exceptions) should be ignored in the shutdown hook.
Failing to close these resources during shutdown is not a major problem, as they
will be garbage collected by the backend anyways. Without this wide catch, some
applications will log a ClassNotFoundException when shutting down, which can be
confusing for end users.

Fixes #949
    @olavloite
    olavloite committed Mar 11, 2021
    Copy the full SHA
    06e24a8 View commit details
    Browse the repository at this point in the history