Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Point In Time Recovery (PITR) samples #824

Closed
wants to merge 1 commit into from
Closed

feat: Point In Time Recovery (PITR) samples #824

wants to merge 1 commit into from

Conversation

thiagotnunes
Copy link
Contributor

Adds samples for PITR.

@thiagotnunes thiagotnunes requested a review from a team as a code owner January 28, 2021 01:10
@thiagotnunes thiagotnunes requested a review from a team January 28, 2021 01:10
@thiagotnunes thiagotnunes requested a review from a team as a code owner January 28, 2021 01:10
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • google-cloud-spanner/src/test/java/com/google/cloud/spanner/admin/database/v1/DatabaseAdminClientTest.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/Backup.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/BackupInfo.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/BackupInfoOrBuilder.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/BackupOrBuilder.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/BackupProto.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CommonProto.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateBackupRequest.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateBackupRequestOrBuilder.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateDatabaseRequest.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateDatabaseRequestOrBuilder.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/Database.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/DatabaseOrBuilder.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreDatabaseRequest.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreDatabaseRequestOrBuilder.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/SpannerDatabaseAdminProto.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/proto/google/spanner/admin/database/v1/backup.proto
  • proto-google-cloud-spanner-admin-database-v1/src/main/proto/google/spanner/admin/database/v1/common.proto
  • proto-google-cloud-spanner-admin-database-v1/src/main/proto/google/spanner/admin/database/v1/spanner_database_admin.proto

@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Jan 28, 2021
@snippet-bot
Copy link

snippet-bot bot commented Jan 28, 2021 •
edited

Here is the summary of changes.

You added 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 28, 2021
@thiagotnunes thiagotnunes added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 28, 2021
@thiagotnunes
Copy link
Contributor Author

This should only be merged after we release a client library version with the PITR feature. (Before that we need to rebase over master).

@thiagotnunes thiagotnunes changed the title feat: pitr samples feat: Point In Time Recovery (PITR) samples Jan 28, 2021
@olavloite
Copy link
Collaborator

@thiagotnunes New samples should be added as standalone samples and follow the guideline in https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/SAMPLE_FORMAT.md. The AddNumericColumn sample could be used as an example.

@thiagotnunes
Copy link
Contributor Author

Closes in favour of #837

ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
@yoshi-automation
chore(all): auto-regenerate .pb.go files (googleapis#708)
807f52c 
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will
update the corresponding PR to depend on the newer version of go-genproto, and
assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot
will not create any more regeneration PRs. If all regen PRs are closed,
gapicgen will create a new set of regeneration PRs once per night.

If you have been assigned to review this PR, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
genbot to assign reviewers to the google-cloud-go PR.

Corresponding google-cloud-go PR: googleapis/google-cloud-go#5030

Changes:

build: upgrade Java microgenerator to v2.2.1
  # v2.2.1

  ## Bug Fixes
  - gax batching regression (googleapis#863) (3a6f168)

  # v2.2.0

  ## Features
  - Add REST AIP-151 LRO suport (cb1b534)
  - enable self signed JWT for http (googleapis#850) (aba0ec0)
  - Implement DIREGAPIC LRO annotations (googleapis#832) (d7b29e0)
  - REGAPIC initial implementation (googleapis#824) (fdcfe70)
  - REGAPIC Multitransport implementation (grpc+rest) (googleapis#833) (445daf4)

  ## Bug Fixes
  - [bazel] fix rest transport handling in assembly rule (googleapis#835) (92f7c1c)
  - DIREGAPIC LRO generated tests logic (googleapis#838) (8ae8e6f)
  - fix diregapic-lro logic (googleapis#834) (957f69a)

  PiperOrigin-RevId: 405492216
  Source-Link: googleapis/googleapis@4381242

docs: clarified meaning of the legacy editions docs: clarified semantic of the streaming APIs
  PiperOrigin-RevId: 405426307
  Source-Link: googleapis/googleapis@a51c341

docs: fix docstring formatting
  Committer: @parthea
  PiperOrigin-RevId: 405015203
  Source-Link: googleapis/googleapis@974ad5b
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
@codyoss
chore: temporarily remove assuredworkloads v1beta1 (googleapis#824)
d2c91c4 
Files were renamed in upcoming commit causing field name clashes.
A new, differently named, file will generate all these types in the
next regen PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lesv lesv

@dzlier-gcp dzlier-gcp

Labels
api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thiagotnunes @olavloite @lesv @dzlier-gcp