Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: closes pool maintainer on invalidation #784

Merged
merged 5 commits into from Jan 17, 2021
Merged

fix: closes pool maintainer on invalidation #784

merged 5 commits into from Jan 17, 2021

Commits on Jan 7, 2021

  1. fix: closes pool maintainer on invalidation 

    When the session pool is marked as invalid, we immediately close the
pool maintainer in order to keep it from trying to replinish the pool.
This way we prevent useless batch create sessions requests.
    @thiagotnunes
    thiagotnunes committed Jan 7, 2021
    Copy the full SHA
    c77378e View commit details
    Browse the repository at this point in the history

  2. fix: checks for pool maintainer closed status 

    When closing the pool, only waits for the pool maintainer to close if it
has not been closed before.
    @thiagotnunes
    thiagotnunes committed Jan 7, 2021
    Copy the full SHA
    12b1db7 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2021

  1. fix: only closes pool maintainer if not closed 

    Makes sure to close the pool maintainer only if it has not been closed
already. Also before returning to the caller, makes sure to mark the
closing as complete if there are no pending closures.
    @thiagotnunes
    thiagotnunes committed Jan 11, 2021
    Copy the full SHA
    6cec291 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2021

  1. fix: avoids npe when closing pool maintainer

    @thiagotnunes
    thiagotnunes committed Jan 12, 2021
    Copy the full SHA
    1363543 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2021

  1. fix: checks pool maintainer is not closed on close 

    Verifies that the pool maintainer is not closed before closing it. Also
moves the check of pendingClosures into the synchronized block to make
sure no stale reads are made.
    @thiagotnunes
    thiagotnunes committed Jan 14, 2021
    Copy the full SHA
    04ffcf5 View commit details
    Browse the repository at this point in the history