Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transaction retry could fail if tx contained failed statements #688

Merged
merged 1 commit into from Dec 9, 2020

Commits on Dec 8, 2020

  1. fix: transaction retry could fail if tx contained failed statements

    Transaction retries in the Connection API / JDBC driver could fail if the following happened:
    1. The initial transaction contains a statement that returns an error that does not invalidate
       the transaction, such as for example a "Table not found" error, and that error is caught and
       handled by the application code.
    2. The retry attempt tries to execute the failed statement to verify that the statement still
       returns the same error. If however the transaction that is used by the retry has been aborted
       immediately before the execution of this statement, the statement will now return Aborted
       instead of the original error. That would be seen as a different error than the initial
       error and would fail the retry attempt.
    
    When the above happens, the Aborted error in the retry should be propagated and the retry
    attempt should be restarted.
    
    Fixes #685
    olavloite committed Dec 8, 2020
    Copy the full SHA
    8e93b72 View commit details
    Browse the repository at this point in the history