Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ResultSet#close() should not throw exceptions from session creation #487

Merged
merged 2 commits into from Oct 1, 2020
Merged

fix: ResultSet#close() should not throw exceptions from session creation #487

merged 2 commits into from Oct 1, 2020

Commits on Oct 1, 2020

  1. fix: ResultSet#close() should not throw exceptions from session creation 

    If a client application requested a session from the session pool, and that request
required a new BatchCreateSessions request that would fail, then the error from the
BatchCreateSessions RPC would be propagated to both the ReadContext#executeQuery(..)
method as well as the ResultSet#close() method. The latter should not happen, as the
close method should silently ignore any errors from the session creation.
    @olavloite
    olavloite committed Oct 1, 2020
    Copy the full SHA
    b66ac4e View commit details
    Browse the repository at this point in the history

  2. docs: clear up comment

    @olavloite
    olavloite committed Oct 1, 2020
    Copy the full SHA
    9e2df84 View commit details
    Browse the repository at this point in the history