Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: close sessions async revert revert #46

Merged
merged 3 commits into from Jan 24, 2020
Merged

perf: close sessions async revert revert #46

merged 3 commits into from Jan 24, 2020

Commits on Jan 24, 2020

  1. Revert "Revert "perf: close sessions async (#24)" (#43)" 

    This reverts commit 809ed88.
    @skuruppu
    skuruppu committed Jan 24, 2020
    Copy the full SHA
    41f47db View commit details
    Browse the repository at this point in the history

  2. Ignore compatibility check failure in internal interfaces. 

    asyncClose() was added to com.google.cloud.spanner.Session and
asyncDeleteSession() was added to
com.google.cloud.spanner.spi.v1.SpannerRpc in #24 which resulted in
binary compatibility test failures. This config allows us to ignore the
failure.
    @skuruppu
    skuruppu committed Jan 24, 2020
    Copy the full SHA
    84c6930 View commit details
    Browse the repository at this point in the history

  3. Annotate SpannerRpc and Session classes as @internalapi. 

    Users shouldn't be implementing these interfaces as they're internal to
the client library implementation.
    @skuruppu
    skuruppu committed Jan 24, 2020
    Copy the full SHA
    da08183 View commit details
    Browse the repository at this point in the history