Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: async connection API #392
feat!: async connection API #392
Changes from 34 commits
ec4cc30
dd27157
2ae9a11
5d28817
b565560
2446111
321d23c
c753e7c
0a80a85
79308b6
8d5a618
2d531c5
1ce6795
a33a31f
9111798
2711d47
895b024
3b8d29e
fdc64a3
c6ff32d
3096ef6
0395413
bb130b1
35210df
2e84dc1
2500e42
24bc392
d671278
a258579
2878257
81b70c3
5c75bee
f1a40ee
a541398
51ef086
ded2101
5989efb
c50f1ed
c5fba07
3e775b1
b6e175a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
executeQueryAsync
method will produce aFuture<ResultSet>
that should be used as the underlying delegate of anAsyncResultSet
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returns the same exception instance if
e
is already aSpannerException
, instead of wrapping aSpannerException
in anotherSpannerException
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The delegate
ResultSet
should not be closed by the callback executor, but only by the executor that fetches and buffers the rows (in theProduceRowsCallable
at line 380)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to public to be accessible from the
com.google.cloud.spanner.connection
package.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allow specifying a buffer size instead of always using a default size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convenience method that will catch and wrap common exceptions.