chore: add a random channel hint with single use transactions while u… #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
…sing multiplexed sessions.
arpan14
force-pushed
the
mux-pr-random-hint
branch
from
2058dc3
to
5ce399a
Compare
arpan14
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
olavloite
reviewed
Apr 29, 2024
Comment on lines
193
to
195
| // with a multiplexed session. But GAX currently uses an AtomicLong to perform round-robin | ||
| // channel selection and that will cause contention issues at high-concurrency. So we are | ||
| // passing a random hint instead of doing GAX round-robin. |
There was a problem hiding this comment.
Please remove this/replace this comment. Gax uses an AtomicInteger to implement round-robin, and that does not introduce any contention.
olavloite
approved these changes
Apr 29, 2024
arpan14
added
the
automerge
harshachinta
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green
bot
merged commit 42650fa
into
googleapis:main
31 of 32 checks passed
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the hint, GAX would do a round-robin on channels. In theory, a random hint would give a better performance than round robin at a high QPS workload. Also YCSB benchmarks suggest having the hint is better for higher QPS.