New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: backend now supports optimizer version for DML #252
Conversation
@skuruppu |
Oooh I have no idea what this error means:
Unfortunately, I don't have the permissions to force-merge PRs. |
This will be fixed by google-cloud-shared-config 0.7.0 which is releasing now. |
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
1 similar comment
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
@stephaniewang526 are these extra auto value changes expected from shared-config 0.7.0? |
@chingor13 Any idea why it seems like Java11 needs to be used for the Code Format build for it to succeed? Or am I missing something there? |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
So the lint error after updating the shared config was because we also need to update .kokoro/build.sh from https://github.com/googleapis/java-spanner/pull/251/files#diff-ce0d2ea7b6085e6c4bd286d0a15a3971 The auto value changes don't seem to be necessary unless you use auto value |
Great, thanks for looking into that. I'll include that change here and try to walk back as many of the other changes as possible while still keeping the build green. Once that's done, I'll try to fix the other PR's that are failing because of the integration test that is fixed by this PR. |
@olavloite is the autovalue change in shared-config affecting you somehow? |
I'm going to merge this in while the build is green. Then I'll get the presubmits running on the other PRs that are blocked. |
Fixes #249 ☕️