Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: close sessions async #24

Merged
merged 6 commits into from Jan 23, 2020
Merged

perf: close sessions async #24

merged 6 commits into from Jan 23, 2020

Commits on Jan 14, 2020

  1. perf: close sessions async

    Sessions should be closed using an async gRPC call in order
    to speed up the closing of a large session pool. Instead of
    using its own executor, which is limited to 8 worker threads,
    to execute asynchronous delete session calls, the session pool
    should use the asynchronous call option in gRPC. This allows a
    larger number of asynchronous delete session calls to be executed
    in parallel and speeds up closing a session pool with a large
    number of sessions.
    
    Testing against a real Cloud Spanner database with a session pool
    containing 1,000 sessions shows the following performance for
    closing the session pool:
    
    Before (3 runs):
    6603ms
    8169ms
    8367ms
    
    After (3 runs):
    1297ms
    1710ms
    1851ms
    
    Fixes #19.
    olavloite committed Jan 14, 2020
    Copy the full SHA
    0239393 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    5b1ee9c View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    426ab82 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    d2ed3bc View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    a2be792 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2020

  1. fix: remove commented code

    olavloite committed Jan 16, 2020
    Copy the full SHA
    8429fc2 View commit details
    Browse the repository at this point in the history