Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make it possible to override backups methods #195

Merged
merged 1 commit into from May 8, 2020
Merged

fix: make it possible to override backups methods #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java
View file
Open in desktop
Expand Up @@ -853,7 +853,7 @@ public Timestamp apply(Operation input) {
}

@Override
public final OperationFuture<Database, RestoreDatabaseMetadata> restoreDatabase(
public OperationFuture<Database, RestoreDatabaseMetadata> restoreDatabase(
final String databaseInstanceName, final String databaseId, String backupName) {
RestoreDatabaseRequest request =
RestoreDatabaseRequest.newBuilder()
Expand Down Expand Up @@ -905,7 +905,7 @@ public Timestamp apply(Operation input) {
}

@Override
public final Backup updateBackup(Backup backup, FieldMask updateMask) {
public Backup updateBackup(Backup backup, FieldMask updateMask) {
acquireAdministrativeRequestsRateLimiter();
UpdateBackupRequest request =
UpdateBackupRequest.newBuilder().setBackup(backup).setUpdateMask(updateMask).build();
Expand All @@ -914,7 +914,7 @@ public final Backup updateBackup(Backup backup, FieldMask updateMask) {
}

@Override
public final void deleteBackup(String backupName) {
public void deleteBackup(String backupName) {
acquireAdministrativeRequestsRateLimiter();
DeleteBackupRequest request = DeleteBackupRequest.newBuilder().setName(backupName).build();
GrpcCallContext context = newCallContext(null, backupName);
Expand Down