Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: NaNs in Mutations are equal and have the same hashcode #1554

Merged
merged 6 commits into from Nov 16, 2021
Merged

feat: NaNs in Mutations are equal and have the same hashcode #1554

merged 6 commits into from Nov 16, 2021

Commits on Nov 15, 2021

  1. feat: NaNs in Values are considered equal 

    Double.NaN and Float.NaN are considered equal when wrapped with the
Float64 Value implementation class.
    @thiagotnunes
    thiagotnunes committed Nov 15, 2021
    Copy the full SHA
    bf25689 View commit details
    Browse the repository at this point in the history

  2. test: test float64array NaN equals and hashcode

    @thiagotnunes
    thiagotnunes committed Nov 15, 2021
    Copy the full SHA
    2ef2bf7 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Revert "test: test float64array NaN equals and hashcode" 

    This reverts commit 2ef2bf7.
    @thiagotnunes
    thiagotnunes committed Nov 16, 2021
    Copy the full SHA
    112ba82 View commit details
    Browse the repository at this point in the history

  2. Revert "feat: NaNs in Values are considered equal" 

    This reverts commit bf25689.
    @thiagotnunes
    thiagotnunes committed Nov 16, 2021
    Copy the full SHA
    575b5fe View commit details
    Browse the repository at this point in the history

  3. feat: loosen equality check for NaNs in mutations 

    NaNs in mutations are considered equal
    @thiagotnunes
    thiagotnunes committed Nov 16, 2021
    Copy the full SHA
    8b62b9a View commit details
    Browse the repository at this point in the history

  4. feat: explain why we relaxed mutation equality

    @thiagotnunes
    thiagotnunes committed Nov 16, 2021
    Copy the full SHA
    e622306 View commit details
    Browse the repository at this point in the history