Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(java): java 17 dependency arguments #1537

Merged
merged 2 commits into from Nov 3, 2021
Merged

fix(java): java 17 dependency arguments #1537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb42cb7
changes without context
yoshi-automation Nov 2, 2021
47477d3
fix(java): java 17 dependency arguments
yoshi-automation Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions .kokoro/dependencies.sh
View file
Open in desktop
Expand Up @@ -38,14 +38,13 @@ function determineMavenOpts() {
| sed -E 's/^(1\.[0-9]\.0).*$/\1/g'
)

if [[ $javaVersion == 17* ]]
if [[ $javaVersion == 17* ]]
then
# MaxPermSize is no longer supported as of jdk 17
echo -n "-Xmx1024m"
else
echo -n "-Xmx1024m -XX:MaxPermSize=128m"
fi

}

export MAVEN_OPTS=$(determineMavenOpts)
Expand Down
4 changes: 2 additions & 2 deletions synth.metadata
View file
Open in desktop
Expand Up @@ -4,7 +4,7 @@
"git": {
"name": ".",
"remote": "https://github.com/googleapis/java-spanner.git",
"sha": "b6a35acb132e5cdb73f1365c0a937759a6d3a73f"
"sha": "e52dfc49c11490703f5e8689f6012752841b77b7"
}
},
{
Expand All @@ -19,7 +19,7 @@
"git": {
"name": "synthtool",
"remote": "https://github.com/googleapis/synthtool.git",
"sha": "d45942be8066ad57bd0509f4a16e1fac78ecc50f"
"sha": "cb2755306975de4c54ea549c9deb25703b3731bb"
}
}
],
Expand Down