Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop databases after sample tests #1401

Merged
merged 1 commit into from Sep 1, 2021

Commits on Aug 31, 2021

  1. fix: drop databases after sample tests

    There was a bug on dropping databases / deleting backups after the
    sample tests where we were trying to delete in the regional instance
    first and if an exception was thrown, we would try to delete on the
    second instance. This did not work, because the delete / drop operations
    do not fail if the database / backup are not found in the instance, the
    call simply returns.
    
    In this PR we have applied both deletes one after the other to fix the
    issue, instead of relying on the exceptions.
    thiagotnunes committed Aug 31, 2021
    Copy the full SHA
    8cbeb0d View commit details
    Browse the repository at this point in the history