Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a test for selecting an array of structs #1108

Merged
merged 1 commit into from Apr 28, 2021

Conversation

olavloite
Copy link
Collaborator

Test to ensure the error in googleapis/java-spanner-jdbc#444 is not present in the Java client library.

@olavloite olavloite requested a review from a team as a code owner April 27, 2021 11:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #1108 (c8926f6) into master (ce095f7) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1108      +/-   ##
============================================
- Coverage     84.91%   84.90%   -0.01%     
+ Complexity     2725     2723       -2     
============================================
  Files           156      156              
  Lines         14410    14410              
  Branches       1379     1379              
============================================
- Hits          12236    12235       -1     
  Misses         1607     1607              
- Partials        567      568       +1     
Impacted Files Coverage Δ Complexity Δ
...ud/spanner/SessionPoolAsyncTransactionManager.java 85.03% <0.00%> (-1.58%) 13.00% <0.00%> (-2.00%)
...ain/java/com/google/cloud/spanner/SessionPool.java 88.82% <0.00%> (ø) 73.00% <0.00%> (-1.00%)
...m/google/cloud/spanner/connection/SpannerPool.java 87.70% <0.00%> (+0.53%) 33.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce095f7...c8926f6. Read the comment docs.

@thiagotnunes thiagotnunes added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 27, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2021
@thiagotnunes thiagotnunes merged commit 906eee4 into master Apr 28, 2021
@thiagotnunes thiagotnunes deleted the test-select-array-of-structs branch April 28, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants