Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transaction retries should not timeout #1009

Merged
merged 1 commit into from Mar 24, 2021
Merged

Commits on Mar 23, 2021

  1. fix: transaction retries should not timeout

    Transactions that are retried because of an aborted transaction use the
    retry settings of the Rollback RPC. This ensures reasonable backoff values.
    It however also meant that transactions that are retried multiple times
    could exceed the total timeout of the retry settings, and that again would
    cause the Aborted error to propagate. This change sets the total timeout
    for transaction retries to 24 hours and disables any max attempts in the
    retry settings to prevent retries to fail because the deadline is exceeded.
    
    Transactions can still fail with timeout errors if individual RPC invocations
    exceed the configured timeout of that RPC. This change only prevents timeouts
    from occurring because of repeated retries of an entire transaction.
    
    Fixes #1008
    olavloite committed Mar 23, 2021
    Copy the full SHA
    6e1d08f View commit details
    Browse the repository at this point in the history