fix: retry cancelled error on first statement in transaction #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the first statement of a read/write transaction fails with a CANCELLED error and the error message is `Read/query was cancelled due to the enclosing transaction being invalidated by a later transaction in the same session.`, then the transaction should be retried, as the error could be caused by a previous statement that was abandoned by the client but still executed by the backend. This could be the case if the statement timed out (on the client) or was cancelled. Fixes #938
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: spanner
Codecov Report
@@ Coverage Diff @@
## master #999 +/- ##
============================================
+ Coverage 85.07% 85.13% +0.06%
- Complexity 2617 2621 +4
============================================
Files 154 154
Lines 14319 14324 +5
Branches 1331 1334 +3
============================================
+ Hits 12182 12195 +13
+ Misses 1569 1566 -3
+ Partials 568 563 -5
Continue to review full report at Codecov.
|
thiagotnunes
approved these changes
Mar 21, 2021
There was a problem hiding this comment.
@olavloite without this fix, the user would just see a cancelled error and no retry would be made automatically, right?
| SpannerException exceptionToThrow; | ||
| if (withBeginTransaction | ||
| && e.getErrorCode() == ErrorCode.CANCELLED | ||
| && e.getMessage().contains("invalidated by a later transaction")) { |
There was a problem hiding this comment.
nit: could we extract a constant for this?
Correct. That is also exactly what happened in #938. |
olavloite
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first statement of a read/write transaction fails with a
CANCELLEDerror and the error message isRead/query was cancelled due to the enclosing transaction being invalidated by a later transaction in the same session., then the transaction should be retried, as the error could be caused by a previous statement that was abandoned by the client but still executed by the backend. This could be the case if the statement timed out (on the client) or was cancelled.Fixes #938