New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: grpc-alts is only used for tests #757
Conversation
@mohanli-ml Is there a specific reason that |
Codecov Report
@@ Coverage Diff @@
## master #757 +/- ##
=========================================
Coverage 85.15% 85.15%
Complexity 2562 2562
=========================================
Files 142 142
Lines 13960 13960
Branches 1331 1331
=========================================
Hits 11887 11887
- Misses 1513 1514 +1
+ Partials 560 559 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mohanli-ml Won't we need alts for the usage of direct path in production? Or is this only necessary for the tests?
If it is needed for production: Why does it need to explicitly be added as a |
@olavloite I wonder why didn't we add it in the |
@thiagotnunes I'm not exactly sure what you mean in this case. This PR puts it in the |
Yes, sorry, what I meant was why didn't we use the |
@olavloite @thiagotnunes DirectPath use ALTS for authentication, but in this repo we only use it for tests, so I think use test scope should be good. Thanks! |
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#5501 Changes: feat(redis): add secondary_ip_range field PiperOrigin-RevId: 427771855 Source-Link: googleapis/googleapis@fed73d4 docs(accessapproval): added resource annotations feat: added flag for implicit dismissal for `DismissDecision` PiperOrigin-RevId: 427766265 Source-Link: googleapis/googleapis@5556c91 docs(billing/budgets): Formatting change from HTML to markdown; Additional clarifications PiperOrigin-RevId: 427761663 Source-Link: googleapis/googleapis@46c5d65 chore: regenerate API index Source-Link: googleapis/googleapis@14fe023 feat(osconfig): Update v1beta protos with recently added features. PatchRollout proto, mig_instances_allowed field to PatchConfig, UpdatePatchDeployment RPC,PausePatchDeployment and ResumePatchDeployment pair of RPCs PiperOrigin-RevId: 427579992 Source-Link: googleapis/googleapis@250797d chore: regenerate API index Source-Link: googleapis/googleapis@d450beb feat(googleads): Protos and build files for Google Ads API v10 Committer: @aohren PiperOrigin-RevId: 427535047 Source-Link: googleapis/googleapis@553cb54 chore: regenerate API index Source-Link: googleapis/googleapis@978e373 feat: Initial release of Video Stitcher API v1 Public Preview PiperOrigin-RevId: 427509057 Source-Link: googleapis/googleapis@b409abd chore: regenerate API index Source-Link: googleapis/googleapis@95b6277 feat(binaryauthorization): Updates the summary of Binary Authorization to include more recently supported platforms, Anthos clusters on VMware and Cloud Run PiperOrigin-RevId: 427481635 Source-Link: googleapis/googleapis@1bc2eca chore: regenerate API index Source-Link: googleapis/googleapis@48b6d01 feat: Adding Certificate Manager v1 API See public documentation at https://cloud.google.com/certificate-manager/docs PiperOrigin-RevId: 427451561 Source-Link: googleapis/googleapis@d5d129f chore: regenerate API index Source-Link: googleapis/googleapis@7a961f3 feat(datacatalog): Add methods and messages related to starring feature feat: Add methods and messages related to business context feature docs: Updates copyright message PiperOrigin-RevId: 427140868 Source-Link: googleapis/googleapis@0f56b69 chore: regenerate API index Source-Link: googleapis/googleapis@c507c8d feat(osconfig): Update osconfig v1 protos PiperOrigin-RevId: 427050266 Source-Link: googleapis/googleapis@010716c chore: regenerate API index Source-Link: googleapis/googleapis@6d0be82 fix!: Remove deprecated v1beta1 API that is no longer available BREAKING CHANGE: PiperOrigin-RevId: 426957789 Source-Link: googleapis/googleapis@42d9ed3
Adding
grpc-alts
as a runtime dependency causes themaven-flatten-plugin
to add the compile time dependencies in the flattened pom. As far as I can tell,grpc-alts
is (currently) only used for testing, so adding it as atest
scoped dependency seems to make more sense to me.Fixes the build error in googleapis/java-spanner-jdbc#293